Blender Git Loki
Git Commits -> Revision b239314
Revision b239314 by Dalai Felinto (multiview) September 2, 2014, 09:54 (GMT) |
Refactor to use view name instead of view id This was is partly from the original code review round. At that time Brecht Van Lommel suggested using names for the API instead of integers (as we do for RenderLayers). I went a bit further and changed *most* of the code to use strings. The only parts that still use view_id are the ones closely related to UserImage. That simplify the code and should make the code easier to understand, review and maintain. I tested many (if not all) of the supported areas, and apparently things are working. But given the size of the intervention I wouldn't be surprised if something stopped working, so please report. |
Commit Details:
Full Hash: b239314f295cbaefc2fb634550ae8852620177f7
Parent Commit: 26ca7de
Lines Changed: +352, -378
49 Modified Paths:
/intern/cycles/blender/blender_session.cpp (+11, -11) (Diff)
/intern/cycles/blender/blender_session.h (+1, -1) (Diff)
/source/blender/blenkernel/BKE_node.h (+1, -1) (Diff)
/source/blender/blenkernel/BKE_scene.h (+3, -0) (Diff)
/source/blender/blenkernel/intern/scene.c (+64, -0) (Diff)
/source/blender/compositor/COM_compositor.h (+2, -1) (Diff)
/source/blender/compositor/intern/COM_compositor.cpp (+3, -3) (Diff)
/source/blender/compositor/intern/COM_CompositorContext.h (+4, -4) (Diff)
/source/blender/compositor/intern/COM_ExecutionSystem.cpp (+2, -2) (Diff)
/source/blender/compositor/intern/COM_ExecutionSystem.h (+1, -1) (Diff)
/source/blender/compositor/intern/COM_Node.cpp (+0, -20) (Diff)
/source/blender/compositor/intern/COM_Node.h (+0, -2) (Diff)
/source/blender/compositor/nodes/COM_CompositorNode.cpp (+2, -1) (Diff)
/source/blender/compositor/nodes/COM_ImageNode.cpp (+3, -5) (Diff)
/source/blender/compositor/nodes/COM_OutputFileNode.cpp (+7, -6) (Diff)
/source/blender/compositor/nodes/COM_RenderLayersNode.cpp (+2, -6) (Diff)
/source/blender/compositor/nodes/COM_SplitViewerNode.cpp (+3, -2) (Diff)
/source/blender/compositor/nodes/COM_SwitchViewNode.cpp (+2, -6) (Diff)
/source/blender/compositor/nodes/COM_ViewerNode.cpp (+3, -2) (Diff)
/source/blender/compositor/operations/COM_CompositorOperation.cpp (+3, -4) (Diff)
/source/blender/compositor/operations/COM_CompositorOperation.h (+4, -3) (Diff)
/source/blender/compositor/operations/COM_OutputFileMultiViewOperation.cpp (+19, -24) (Diff)
/source/blender/compositor/operations/COM_OutputFileMultiViewOperation.h (+2, -2) (Diff)
/source/blender/compositor/operations/COM_OutputFileOperation.cpp (+6, -35) (Diff)
/source/blender/compositor/operations/COM_OutputFileOperation.h (+4, -6) (Diff)
/source/blender/compositor/operations/COM_RenderLayersProg.cpp (+3, -3) (Diff)
/source/blender/compositor/operations/COM_RenderLayersProg.h (+4, -4) (Diff)
/source/blender/compositor/operations/COM_ViewerOperation.cpp (+4, -1) (Diff)
/source/blender/compositor/operations/COM_ViewerOperation.h (+5, -3) (Diff)
/source/blender/editors/render/render_internal.c (+6, -5) (Diff)
/source/blender/editors/render/render_preview.c (+1, -1) (Diff)
/source/blender/editors/space_node/node_edit.c (+4, -4) (Diff)
/source/blender/freestyle/intern/blender_interface/FRS_freestyle.cpp (+2, -2) (Diff)
/source/blender/imbuf/intern/openexr/openexr_api.cpp (+21, -40) (Diff)
/source/blender/imbuf/intern/openexr/openexr_multi.h (+2, -5) (Diff)
/source/blender/imbuf/intern/openexr/openexr_stub.cpp (+0, -3) (Diff)
/source/blender/makesrna/intern/rna_render.c (+10, -6) (Diff)
/source/blender/nodes/composite/node_composite_tree.c (+3, -3) (Diff)
/source/blender/render/extern/include/RE_engine.h (+2, -2) (Diff)
/source/blender/render/extern/include/RE_pipeline.h (+3, -3) (Diff)
/source/blender/render/intern/include/render_result.h (+4, -3) (Diff)
/source/blender/render/intern/include/render_types.h (+2, -2) (Diff)
/source/blender/render/intern/source/envmap.c (+1, -1) (Diff)
/source/blender/render/intern/source/external_engine.c (+8, -8) (Diff)
/source/blender/render/intern/source/initrender.c (+3, -9) (Diff)
/source/blender/render/intern/source/pipeline.c (+66, -68) (Diff)
/source/blender/render/intern/source/rendercore.c (+19, -19) (Diff)
/source/blender/render/intern/source/render_result.c (+24, -32) (Diff)
/source/blender/render/intern/source/zbuf.c (+3, -3) (Diff)
/intern/cycles/blender/blender_session.h (+1, -1) (Diff)
/source/blender/blenkernel/BKE_node.h (+1, -1) (Diff)
/source/blender/blenkernel/BKE_scene.h (+3, -0) (Diff)
/source/blender/blenkernel/intern/scene.c (+64, -0) (Diff)
/source/blender/compositor/COM_compositor.h (+2, -1) (Diff)
/source/blender/compositor/intern/COM_compositor.cpp (+3, -3) (Diff)
/source/blender/compositor/intern/COM_CompositorContext.h (+4, -4) (Diff)
/source/blender/compositor/intern/COM_ExecutionSystem.cpp (+2, -2) (Diff)
/source/blender/compositor/intern/COM_ExecutionSystem.h (+1, -1) (Diff)
/source/blender/compositor/intern/COM_Node.cpp (+0, -20) (Diff)
/source/blender/compositor/intern/COM_Node.h (+0, -2) (Diff)
/source/blender/compositor/nodes/COM_CompositorNode.cpp (+2, -1) (Diff)
/source/blender/compositor/nodes/COM_ImageNode.cpp (+3, -5) (Diff)
/source/blender/compositor/nodes/COM_OutputFileNode.cpp (+7, -6) (Diff)
/source/blender/compositor/nodes/COM_RenderLayersNode.cpp (+2, -6) (Diff)
/source/blender/compositor/nodes/COM_SplitViewerNode.cpp (+3, -2) (Diff)
/source/blender/compositor/nodes/COM_SwitchViewNode.cpp (+2, -6) (Diff)
/source/blender/compositor/nodes/COM_ViewerNode.cpp (+3, -2) (Diff)
/source/blender/compositor/operations/COM_CompositorOperation.cpp (+3, -4) (Diff)
/source/blender/compositor/operations/COM_CompositorOperation.h (+4, -3) (Diff)
/source/blender/compositor/operations/COM_OutputFileMultiViewOperation.cpp (+19, -24) (Diff)
/source/blender/compositor/operations/COM_OutputFileMultiViewOperation.h (+2, -2) (Diff)
/source/blender/compositor/operations/COM_OutputFileOperation.cpp (+6, -35) (Diff)
/source/blender/compositor/operations/COM_OutputFileOperation.h (+4, -6) (Diff)
/source/blender/compositor/operations/COM_RenderLayersProg.cpp (+3, -3) (Diff)
/source/blender/compositor/operations/COM_RenderLayersProg.h (+4, -4) (Diff)
/source/blender/compositor/operations/COM_ViewerOperation.cpp (+4, -1) (Diff)
/source/blender/compositor/operations/COM_ViewerOperation.h (+5, -3) (Diff)
/source/blender/editors/render/render_internal.c (+6, -5) (Diff)
/source/blender/editors/render/render_preview.c (+1, -1) (Diff)
/source/blender/editors/space_node/node_edit.c (+4, -4) (Diff)
/source/blender/freestyle/intern/blender_interface/FRS_freestyle.cpp (+2, -2) (Diff)
/source/blender/imbuf/intern/openexr/openexr_api.cpp (+21, -40) (Diff)
/source/blender/imbuf/intern/openexr/openexr_multi.h (+2, -5) (Diff)
/source/blender/imbuf/intern/openexr/openexr_stub.cpp (+0, -3) (Diff)
/source/blender/makesrna/intern/rna_render.c (+10, -6) (Diff)
/source/blender/nodes/composite/node_composite_tree.c (+3, -3) (Diff)
/source/blender/render/extern/include/RE_engine.h (+2, -2) (Diff)
/source/blender/render/extern/include/RE_pipeline.h (+3, -3) (Diff)
/source/blender/render/intern/include/render_result.h (+4, -3) (Diff)
/source/blender/render/intern/include/render_types.h (+2, -2) (Diff)
/source/blender/render/intern/source/envmap.c (+1, -1) (Diff)
/source/blender/render/intern/source/external_engine.c (+8, -8) (Diff)
/source/blender/render/intern/source/initrender.c (+3, -9) (Diff)
/source/blender/render/intern/source/pipeline.c (+66, -68) (Diff)
/source/blender/render/intern/source/rendercore.c (+19, -19) (Diff)
/source/blender/render/intern/source/render_result.c (+24, -32) (Diff)
/source/blender/render/intern/source/zbuf.c (+3, -3) (Diff)
Master Commits
MiikaH:n Sivut a.k.a. MiikaHweb | 2003-2021