Blender Git Loki

Git Commits -> Revision b41ce0d

Revision b41ce0d by Nicholas Bishop (master)
January 15, 2015, 13:00 (GMT)
Remove 'locked' parameter from sound_read_waveform()

This parameter was confusing in three ways:

1. It should have been named "lock" because it was used to take and
release the sound mutex, not to indicate whether it was locked.

2. In the one place this function gets called the locked argument was
set to "true", so not much point in having it optional.

3. I can't imagine that it would ever be a good idea to skip taking
and releasing the mutex.

Reviewed By: sergey

Differential Revision:

Commit Details:

Full Hash: b41ce0d1b95973c64bb4300a20c1b89506fe32d0
Parent Commit: 588656a
Lines Changed: +8, -12

3 Modified Paths:

/source/blender/blenkernel/BKE_sound.h (+1, -1) (Diff)
/source/blender/blenkernel/intern/sound.c (+6, -10) (Diff)
/source/blender/editors/space_sequencer/sequencer_preview.c (+1, -1) (Diff)
Tehnyt: Miika HämäläinenViimeksi päivitetty: 07.11.2014 14:18MiikaH:n Sivut a.k.a. MiikaHweb | 2003-2021