Blender Git Loki

Git Commits -> Revision bbb52a4

Revision bbb52a4 by Falk David (master)
April 22, 2021, 17:02 (GMT)
Fix T87688: Crash entering valid text into number field

When the user entered a driver expression like `#frame` into a number
field, Blender would crash sometime after. This is because
e1a9ba94c599 did not handle this case properly and ignored the fact
that the user can enter text into the field.

The fix makes sure that we only cancel if the value is a *number* equal
to the previous value in the field.

Note that this could also be handled by `ui_but_string_set` which would
be a bit nicer potentially. However, I was unable to find a clean way of
passing `data->startvalue` into that function. `uiHandleButtonData` is
only known locally inside `interface_handlers.c`.

Reviewed By: Severin

Maniphest Tasks: T87688

Differential Revision: https://developer.blender.org/D11049

Commit Details:

Full Hash: bbb52a462ef91c9f84f673102b851a897b5968ac
Parent Commit: d1ccc5b
Lines Changed: +7, -6

1 Modified Path:

/source/blender/editors/interface/interface_handlers.c (+7, -6) (Diff)
Tehnyt: Miika HämäläinenViimeksi päivitetty: 07.11.2014 14:18MiikaH:n Sivut a.k.a. MiikaHweb | 2003-2021