Blender Git Loki

Git Commits -> Revision bd11d91

Revision bd11d91 by Mike Erwin (master)
July 23, 2016, 01:00 (GMT)
fix atan2f input conditional

Suspicious conditional found by PVS-Studio T48917

Original code (from Blender?s initial open-source commit!) looks like
it?s testing inputs to atan2f, to avoid undefined function values.
Passing xn=0 does *not* always evaluate to 0 though? I?m not sure if
this is a coding error or was done for a desired visual result.

Also changed xn==0 to xn>=0 to avoid function call in more cases.

Good description and visualization of atan2f function:
http://en.cppreference.com/w/c/numeric/math/atan2

Commit Details:

Full Hash: bd11d917c19aab91df9c2c7c721233fa73a1d1d7
Parent Commit: 164575a
Lines Changed: +2, -2

1 Modified Path:

/source/blender/render/intern/source/renderdatabase.c (+2, -2) (Diff)
Tehnyt: Miika HämäläinenViimeksi päivitetty: 07.11.2014 14:18MiikaH:n Sivut a.k.a. MiikaHweb | 2003-2021