Blender Git Loki

Git Commits -> Revision cdc7a24

Revision cdc7a24 by Bastien Montagne (master)
July 29, 2016, 15:00 (GMT)
Fix T48971: Append creates linked image textures if object has shape keys.

Hating all those not-so-real ID types... Here there were two causes for the issue:
1) Linked shapekey ID was made local twice (once from mesh's make local, once by itself).
Solved by not explicitely making shapekeys (nor any other non-linkable datatype) local.
2) Key->from 'back pointer' to its owner was messing 'still in used' detection of linked data
after localization. Fixed with a hack for now, thinking correct solution might actually
be to not consider this pointer at all in libquery ID looper, since it's nothing like
and actual usage of mesh/lattice/curve.

Again, shapekeys as ID is a joke, those should be mere struct, they have absolutely nothing to do in Main, period. :(

Point 2) still demonstrates the need for better handling of IDs dependencies though,
so far we only hit corner cases, but think there could also be valid cases generating those
'dependency cycles' between IDs (ID a using ID b which uses ID a), this will have to be addressed some day...

Commit Details:

Full Hash: cdc7a24d7b56aed874aefe4d37c6acb1cfcae346
Parent Commit: 8213949
Lines Changed: +22, -3

2 Modified Paths:

/source/blender/blenkernel/intern/library.c (+9, -2) (Diff)
/source/blender/blenkernel/intern/library_query.c (+13, -1) (Diff)
Tehnyt: Miika HämäläinenViimeksi päivitetty: 07.11.2014 14:18MiikaH:n Sivut a.k.a. MiikaHweb | 2003-2021