Blender Git Loki

Blender Git "multiview" branch commits.

Page: 8 / 19

November 26, 2014, 18:19 (GMT)
From review: keep err_out at the end of draw_offscreen_imbuf*() routines
November 26, 2014, 14:15 (GMT)
From review: all chars in blender are unsigned, no need special math
utils function just cast/call the _char functions
November 26, 2014, 13:11 (GMT)
From review: favour anonymous Enum over defines
November 26, 2014, 13:11 (GMT)
From review: rename 'eye' to 'multiview_eye'
November 26, 2014, 13:11 (GMT)
From review: use !=0 when handling flags
November 26, 2014, 13:11 (GMT)
From review: rename views_setup by views_format
November 26, 2014, 13:11 (GMT)
From review: rename 'use_multiple_views' to 'use_multiview'
November 26, 2014, 13:11 (GMT)
From review: use _arr for arrays
November 26, 2014, 11:57 (GMT)
From review: use STRPREFIX instead of strstr
November 26, 2014, 11:51 (GMT)
From review: cleanup top-bottom and side-by-side drawing loops
November 26, 2014, 01:34 (GMT)
From review: replace sprintf by BLI_snprintf
November 26, 2014, 01:33 (GMT)
From review: small change and a new TODO to the list:

If a movie fails for one view what to do?
November 25, 2014, 21:27 (GMT)
Bugfix: ammend from previous commit, camera border was still failing in some cases
November 25, 2014, 20:33 (GMT)
Bugfix: camera border not showing when 'show_stereo_3d_cameras' is disabled

(reported on review)
November 25, 2014, 16:55 (GMT)
From review: changes in BKE_image_has_anim() and BKE_image_has_packedfile()

Comments by Sergey Sharybin:

* If packedFile becomes NULL for some and ima->packedfiles has still
elements this sounds like a horrible error happened somewhere.

* If anims has items then the image is an animation. Imagine situation
when you load movie file in image editor, save .blend file, then
remove the movie file and re-load the file. Seems this case should be
considered image is an animation i guess.
November 25, 2014, 15:44 (GMT)
From review: revert uneeded change in branch
November 25, 2014, 15:39 (GMT)
From review: image is calloc'ed, no need to initialize ListBases to NULL
November 25, 2014, 15:39 (GMT)
From review: use BLI_duplicatelist and fix for copy_image_anims

It makes no sense to have a ImageAnima when the struct anim itself is
NULL;
November 25, 2014, 15:39 (GMT)
From review: use BLI_freelistN
November 25, 2014, 15:39 (GMT)
From review: fixing GPL header
Tehnyt: Miika HämäläinenViimeksi päivitetty: 07.11.2014 14:18MiikaH:n Sivut a.k.a. MiikaHweb | 2003-2021