Blender Git Loki

Merge branch 'search-button-allow-all' into temp-geometry-nodes-attribute-search

Merge branch 'master' into search-button-allow-all

Merge branch 'master' into temp-geometry-nodes-attribute-search

UI: Add an option to search buttons to allow any string input

For geometry nodes we will use search buttons to display a list of
attributes available the last time the node tree was executed (D10519).
Because this list is just a hint, we need to be able to enter any string,
not just strings from the search items.

This patch adds a boolean option to string buttons to enable this.
The change is quite simple, changes to behavior are only required in
two places. The type-specific button struct changes help a lot here.

Differential Revision: https://developer.blender.org/D10527

Merge branch 'master' into temp-geometry-nodes-attribute-search

Cleanup: Rename function, remove TODO comment

Cleanup: Switch order of checks

Merge branch 'master' into temp-geometry-nodes-attribute-search

Attribute Search: Deduplicate function

Merge branch 'master' into temp-geometry-nodes-attribute-search

Attribute Search: Accept all strings as valid results

Since the names in the search box are only hints, any attribute name
is potentially valid. Error messages can tell when it is not.

Attribute Search: Remove more debug prints

Merge branch 'master' into temp-geometry-nodes-attribute-search

Attribute Search: Remove debug prints

Attribute Search: Use attribute names from UI storage

For now, this means that only nodes with error messages will have
an interactive list of attribute names, and it's still the dummy data.

Attribute Search: Fix interaction with buttons not working

When an "exec" function was set, the data argument was provided to
the button. This meant that two of these buttons won't be considered
"equal" over successive redraws, since the data is reallocated every time.
To maintain "active" status over redraws, that new-button to old-button
map needs to be valid,, and it wasn't so the buttons weren't active.

The take-away: search button arguments can not be reallocated for every
redraw if an exec function is provided.

Since I have since connected the search button to the "default_value"
RNA property, we don't actually need the manual "exec" function anyway,
so this commit just removes it.

Attribute Search: Mirror fix from rB1239cab11ff97f

I tried adding this as one of the fixes to fix the interaction with the
attribute name buttons. It didn't fix that problem, but I'm not sure
I should remove it since it seemed to fix a valid situation where the
button pointer changed for RNA collection search.

Merge branch 'master' into temp-geometry-nodes-attribute-search

Attribute Search: Always add current value to the search list

This way the button isn't red if the socket value is any of
"HELLO!", "DOES", "THIS", "WORK???".

And the answer is no, it doesn't work, because all buttons are still
not interactive. I haven't been able to figure out why, but the UI code
doesn't see them as active (i.e. they are deactivated before they can
open the menu).

Attribute Search: Attempt to fix disabled button