Blender Git Loki

Cycles: Fix CUDA kernel compilation error

Was broken with aa_samples removal.

Comment out the offending cryptomatte code. It needs to be looked
closely and redone anyway. Was probably wrong with adaptive sampling.

Fix T87007: Cycles Background not updated if strength is initially null

When the strength is initially set to zero, the shader graph is
optimized out to remove any node which will not be executed because of
this, which removes pretty much every single node, except for the
output. As the graph is empty, the world shader is made invisible to
rays so it is not evaluated in the kernel.

However, when the strength is then modified, the Background is not
updated as the modification happens on the Shader Node and not on the
Background Node, so it is never tagged as modified.

To fix this, we need to tag the Background as modified when its shader
is also modified so the Kernel data is properly updated.

Regression caused by rBbbe6d44928235cd4a5cfbeaf1a1de78ed861bb92.

Cycles: Remove resolution divider from KernelCamera

Cycles: Remove conditional AA samples update

It was only needed for CMJ to work.

The baking is unclear why it was needed, since the feature set which
depends on number of AA samples is either unsupported for bake (such
as adaptive sampling) or is not needed since CMJ removal.

Cycles: Remove unused aa_samples from KernelIntegrator

Was needed for CMJ to work, but we no longer have CMJ and we are only
interested in patters which are progressive.

Cycles: Remove unused CMJ enum

Cycles: Remove path_trace kernel

It is implemented using PathTrace and PathTraceWork.

Cycles: Remove or comment out end-of-life code

The goal is to make API clean, and stop worrying about keeping it
compilable. The most interesting bits of implementation which we
will need to reference for the new implementation are `#if 0`-ed.

The code which is either migrated or which is known to be not needed
is removed.

Summary:

- Remove `DeviceTask` and `Device::task_foo`
It is replaced with either queue or CPUKernels.

- Comment out NLM denoiser.
Can probably remove it. But lets have a quick meeting about it.

- Remove old OpenImageDenoiser implementation.
It is now implemented in integrator/denoiser.

- Commented out render/denoiser. It is to be ported to the new
denoiser implementation in inetgrator/. Also, if NLM is removed then
feature-parity is not really possibly at this time.

- Comment out device_denoiser.

Cycles: Remove unused update_scene() function

Cycles: Remove dead code from Session

The code is not reachable, not testable, and unlikely to be needed for
the final implementation. Remove it to make ongoing development and
maintenance cleaner.

For the reference we can always consult code from the previous Cycles
releases.

There are still some `#if 0` in the `session.cpp` but they are not in
a way and can be removed later on.

Cycles: Remove film conversion to byte buffer

The motivation is that such conversion is faster to be performed as
a fragment shader.

For platforms and configurations which can not use fragment shader
an alternative would be to implement it in the GPUDisplay level.

If this functionality is really something what a lot of Cycles
adopters are needing, we can reconsider this. Until then is better
to keep an API small and clean.

Cycles: Use typed function for convert_to_half_float kernel

Cycles: Remove redundant type prefix

Types are defined within CPUKernels, so the CPU prefix is redundant.

Cycles: Remove residue of FILM_CONVERT task

It is taken care of in GPUDisplay.

Cycles: Improve start resolution calculation

Take denoising and display update times into account.

Additionally, lower update interval when denoising will happen on
a scaled down render. This way denoiser have more pixels to work
with, avoiding a blurry mess in the cost of less interactive
navigation.

Cycles: Keep track of average GPU display update time

Cycles: De-duplicate average time reset logic

Cleanup: Extra spaces at the end of comment

Cycles: Unify device variable name

Just stick to a commonly used `device`. The original idea of making it
clear that the device is actual a compute (non-multi) device didn't
really work that great.

Cycles: Enable all passes for OpenImageDenoiser

Finishes the OpenImageDenoiser re-implementation to the same feature
level as it was before the big refactor.