Blender Git Loki

Cycles-X: Fix incorrect performance calculation at certain navigation resolutions

During viewport navigation the algorithm that calculates the resolution divider assumes that the at every resolution division the sample count will be 4. This is not true for cases where the resolution division is equal to `2 * pixel_size` and `pixel_size`. In those cases the sample count is 1. As a result the algorithm assumes `2 * pixel_size` and `pixel_size` are too expensive in a lot of cases and thus doesn't use it.

This patch addresses this issue by informing the algorithm of changes in sample counts between resolution divisions meaning it can more properly gauge the performance of various resolution divisions. As a result the algorithm is more likely to pick the correct resolution divider when performance of the scene is in the range that `2 * pixel_size` and `pixel_size` are viable options all while keeping the performance target at 30fps like before.

Along with this patch the sample count while the resolution divider is equal to `2 * pixel_size` has been increased from 1 sample per pixel to 2 samples per pixel. Without an increase to this value there are some negative side effects. I have chosen the value of 2 and not 4 because this values means at a resolution divider of `2 * pixel_size` the rendering is still cheaper than a resolution divider of `pixel_size`.

Differential Revision: https://developer.blender.org/D12367

use GFieldRef where appropriate

fix bug when the same field is evaluated twice

add initial Attribute Freeze node

Small fix of using defined constant instead of immediate value

support deduplication of normal node

fix typo

Merge branch 'master' into temp-geometry-nodes-fields

commit working code

Cleanup and improve comment

Add initial normal node

In contrast with the read-only "normal" attribute on the face domain,
this node gives normalized values for every mesh domain, including
edges and corners. This is preferrable since it's much more predictable
to work with.

The implementation is a little more complicated than I would like,
but could be improved with const access to lazy calculation of normals
on meshes, which is something I've been planning to work on anyway.

Fix function and define names

Cleanup: Internally rename "position" to "input_position"

Maybe we'll decide not to do this, for now maybe it's better to be consistent though

Cleanup: Rename index node define

Add "Index" node

Allow Set Position node to act on more component types, cleanup

Add a special case for a selection span

This will probably end up being a utility used elsewhere,
so it's worth adding this case.

Reorder input sockets

Since the position is the more important input compared to the
selection, it should be on top

Cleanup: Remove unnecessary include

Merge branch 'master' into temp-geometry-nodes-fields