Blender Git Loki
Git Commits -> Revision 28604c4
Revision 28604c4 by Sergey Sharybin (master) February 12, 2016, 14:27 (GMT) |
Cycles: Make Blender importer more forward compatible Basically the idea is to make code robust against extending enum options in the future by falling back to a known safe default setting when RNA is set to something unknown. While this approach solves the issues similar to T47377, but it wouldn't really help when/if any of the RNA values gets ever deprecated and removed. There'll be no simple solution to that apart from defining explicit mapping from RNA value to Cycles one. Another part which isn't so great actually is that we now have to have some enum guards and give some explicit values to the enum items, but we can live with that perhaps. Reviewers: dingto, juicyfruit, lukasstockner97, brecht Reviewed By: brecht Differential Revision: https://developer.blender.org/D1785 |
Commit Details:
Full Hash: 28604c46a137c1288cc7a494b36ed72e44a0ab8b
Parent Commit: ec99778
Lines Changed: +203, -101
17 Modified Paths:
/intern/cycles/blender/blender_camera.cpp (+14, -41) (Diff)
/intern/cycles/blender/blender_curves.cpp (+10, -2) (Diff)
/intern/cycles/blender/blender_mesh.cpp (+4, -1) (Diff)
/intern/cycles/blender/blender_shader.cpp (+59, -15) (Diff)
/intern/cycles/blender/blender_sync.cpp (+18, -4) (Diff)
/intern/cycles/blender/blender_util.h (+18, -3) (Diff)
/intern/cycles/device/device_cuda.cpp (+2, -0) (Diff)
/intern/cycles/kernel/kernel_compat_cpu.h (+12, -0) (Diff)
/intern/cycles/kernel/kernel_types.h (+9, -5) (Diff)
/intern/cycles/render/camera.h (+8, -4) (Diff)
/intern/cycles/render/curves.h (+24, -20) (Diff)
/intern/cycles/render/film.h (+3, -1) (Diff)
/intern/cycles/render/integrator.h (+3, -1) (Diff)
/intern/cycles/render/mesh.h (+5, -3) (Diff)
/intern/cycles/render/scene.h (+6, -1) (Diff)
/intern/cycles/render/shader.h (+4, -0) (Diff)
/intern/cycles/util/util_types.h (+4, -0) (Diff)
/intern/cycles/blender/blender_curves.cpp (+10, -2) (Diff)
/intern/cycles/blender/blender_mesh.cpp (+4, -1) (Diff)
/intern/cycles/blender/blender_shader.cpp (+59, -15) (Diff)
/intern/cycles/blender/blender_sync.cpp (+18, -4) (Diff)
/intern/cycles/blender/blender_util.h (+18, -3) (Diff)
/intern/cycles/device/device_cuda.cpp (+2, -0) (Diff)
/intern/cycles/kernel/kernel_compat_cpu.h (+12, -0) (Diff)
/intern/cycles/kernel/kernel_types.h (+9, -5) (Diff)
/intern/cycles/render/camera.h (+8, -4) (Diff)
/intern/cycles/render/curves.h (+24, -20) (Diff)
/intern/cycles/render/film.h (+3, -1) (Diff)
/intern/cycles/render/integrator.h (+3, -1) (Diff)
/intern/cycles/render/mesh.h (+5, -3) (Diff)
/intern/cycles/render/scene.h (+6, -1) (Diff)
/intern/cycles/render/shader.h (+4, -0) (Diff)
/intern/cycles/util/util_types.h (+4, -0) (Diff)