Blender Git Loki
Git Commits -> Revision 654ef11
Revision 654ef11 by Sergey Sharybin (master) May 27, 2012, 10:08 (GMT) |
Fix #31606: pg up/down does not work for changing falloff for proportional editing Initially issue was caused by non-proportional edge slide patch in rev46927 which had several wrong things: - It introduced new events TFM_WHEEL_DOWN_EVT/TFM_WHEEL_UP_EVT which were defined as per-bit OR between edge slide and proportional editing modal events, but the issue is that modal events are not bit masks and that meant that new events were defined as 20|24 and 21|25 which is a bit strange. - Another this was caused by the fact, that keymap wasn't creating for some specific transform modal keymap item -- it used to be tried to create single shortcut for two different modal events, which isn't supported by keymaps and resulted by artifacts in keymap editor interface (nodal event type was empty for wheel movements). That was caused by different events used by modal keymap and defining shortcuts. - Actual issue which prevented PgUP/PGDOWN to work was mixing using that new events for wheel scrolling in switch statements which doesn't do bitmask check. Solved by separating keymaps used for proportional editing and edge slide -- now it's mouse Wheel for proportional editing and Alt-Wheel for edge slide. If someone would want to have single shortcut for this two events it'll imply one of the follofing things: - Support poll function for shortcuts, so keymap would definitely know which modal event to send to operator. - Generalize TFM_MODAL_PROPSIZE_{UP, DOWN} and TFM_MODAL_EDGESLIDE_{UP, DOWN} so they can share the same shortcut with current design of keymaps. |
Commit Details:
Full Hash: 654ef111a7d239501599faee62579c8c600fe67a
SVN Revision: 47064
Parent Commit: 9978f97
Lines Changed: +13, -9
1 Modified Path:
/source/blender/editors/transform/transform.c (+13, -9) (Diff)