Blender Git Loki

Git Commits -> Revision 7e82396

Revision 7e82396 by Sergey Sharybin (master)
May 12, 2021, 08:06 (GMT)
Fix non-finite tangent in Cycles with missing UV map

Was causing calculation issues later on in the kernel.

This change catches the most obvious case: missing attribute. The old
code was trying to set tangent to 0, but because it was transformed as
a normal it got converted to non-finite value. This change makes it so
that no transform is involved and 0 is written directly to the SVM
stack.

To cover all cases it will require using safe_normalize() in this node
and in the normal transform function. This is more involved change from
performance point of view, would be nice to verify whether we really want
to go this route.

I've left asserts in the BSDF allocation functions. Don't have strong
connection to them, but think they are handy and are not different from
having an assert in the path radiance checks.

Differential Revision: https://developer.blender.org/D11235

Commit Details:

Full Hash: 7e823969b59487c5dc2f032424a12365aa95145c
Parent Commit: 7f34363
Lines Changed: +10, -3

2 Modified Paths:

/intern/cycles/kernel/closure/alloc.h (+4, -0) (Diff)
/intern/cycles/kernel/svm/svm_tex_coord.h (+6, -3) (Diff)
Tehnyt: Miika HämäläinenViimeksi päivitetty: 07.11.2014 14:18MiikaH:n Sivut a.k.a. MiikaHweb | 2003-2021