Blender Git Loki

Git Commits -> Revision 83ce028

Revision 83ce028 by Sergey Sharybin (master)
October 6, 2017, 16:06 (GMT)
Cycles: Fix possible race condition when generating Beckmann table

Two issues here:

- Checking table size to be non-zero is not a proper way to go here. This is
because we first resize the table and then fill it in. So it was possible that
non-initialized table was used.

Trickery with using temporary memory and then doing table.swap() might work,
but we can not guarantee that table size will be set after the data pointer.

- Mutex guard was useless, because every thread was using own mutex. Need to
make mutex guard static so all threads are using same mutex.

Commit Details:

Full Hash: 83ce02879f7c6733adc098d00a01963fc4212abd
Parent Commit: 837383a
Lines Changed: +7, -3

2 Modified Paths:

/intern/cycles/render/shader.cpp (+5, -2) (Diff)
/intern/cycles/render/shader.h (+2, -1) (Diff)
Tehnyt: Miika HämäläinenViimeksi päivitetty: 07.11.2014 14:18MiikaH:n Sivut a.k.a. MiikaHweb | 2003-2021