Blender Git Loki
Git Commits -> Revision 87dcee0
Revision 87dcee0 by Sergey Sharybin (master) April 22, 2016, 08:59 (GMT) |
Silence some annoying warnings when doing full build with strict flags This mainly touches extern libraries and few debug-only places in intern. Some summary: - External libraries are not strict at all about missing declarations, so we can rather safely remove such warning together with other strict flags. - Bullet has some static functions which are not used. Those were commented out. - Carve now has some unused debug-only functions commented out as well. While we're on the way of getting rid of Carve, it makes sense to make things a bit cleaner for the time being. - In LZMA we have some parts disabled which gives some set but unused variables which is rather correct. - Elbeem had quite some variables set and never used because their usage is inside of debug-only code which is commented out. Note about patching upstream libraries: surely one might say that we have to make local patchset against this, but own experience says it only gives extra work trying to merge such tweaks to a new upstream version and usually it's just faster to re-apply such fixes again after bundling new upstream library. |
Commit Details:
Full Hash: 87dcee0c0c33ab2f2a8d22e0d0b53f0289ef7a46
Parent Commit: d2cb0f9
Lines Changed: +48, -19
16 Modified Paths:
/build_files/cmake/macros.cmake (+1, -0) (Diff)
/extern/bullet2/src/BulletDynamics/Featherstone/btMultiBody.cpp (+2, -0) (Diff)
/extern/bullet2/src/BulletSoftBody/btSoftBodyHelpers.cpp (+5, -4) (Diff)
/extern/bullet2/src/BulletSoftBody/btSoftBodyInternals.h (+2, -2) (Diff)
/extern/carve/lib/geom2d.cpp (+4, -0) (Diff)
/extern/carve/lib/geom3d.cpp (+2, -0) (Diff)
/extern/carve/lib/intersect.cpp (+7, -3) (Diff)
/extern/carve/lib/intersect_classify_edge.cpp (+4, -1) (Diff)
/extern/carve/lib/intersect_face_division.cpp (+2, -0) (Diff)
/extern/carve/lib/math.cpp (+6, -0) (Diff)
/extern/carve/lib/mesh.cpp (+0, -2) (Diff)
/extern/lzma/LzmaEnc.c (+1, -2) (Diff)
/intern/elbeem/intern/loop_tools.h (+3, -0) (Diff)
/intern/elbeem/intern/ntl_ray.cpp (+3, -3) (Diff)
/intern/elbeem/intern/solver_init.cpp (+4, -2) (Diff)
/intern/elbeem/intern/solver_main.cpp (+2, -0) (Diff)
/extern/bullet2/src/BulletDynamics/Featherstone/btMultiBody.cpp (+2, -0) (Diff)
/extern/bullet2/src/BulletSoftBody/btSoftBodyHelpers.cpp (+5, -4) (Diff)
/extern/bullet2/src/BulletSoftBody/btSoftBodyInternals.h (+2, -2) (Diff)
/extern/carve/lib/geom2d.cpp (+4, -0) (Diff)
/extern/carve/lib/geom3d.cpp (+2, -0) (Diff)
/extern/carve/lib/intersect.cpp (+7, -3) (Diff)
/extern/carve/lib/intersect_classify_edge.cpp (+4, -1) (Diff)
/extern/carve/lib/intersect_face_division.cpp (+2, -0) (Diff)
/extern/carve/lib/math.cpp (+6, -0) (Diff)
/extern/carve/lib/mesh.cpp (+0, -2) (Diff)
/extern/lzma/LzmaEnc.c (+1, -2) (Diff)
/intern/elbeem/intern/loop_tools.h (+3, -0) (Diff)
/intern/elbeem/intern/ntl_ray.cpp (+3, -3) (Diff)
/intern/elbeem/intern/solver_init.cpp (+4, -2) (Diff)
/intern/elbeem/intern/solver_main.cpp (+2, -0) (Diff)