Blender Git Loki

Git Commits -> Revision a7172d3

Revision a7172d3 by Julian Eisel (temp-workspace_mode)
December 15, 2017, 15:40 (GMT)
Possible solution for workspace mode

Basically implements the proposal made in [[https://developer.blender.org/T53389#474275|this comment]].
Important to note: This implementation keeps the mode stored in the object, the workspace takes care for setting it though.
Even if we decide to move the mode out of the object, most code here would still be valid. This is just a much more feasible approach that may suit our needs already.

The basic rule for setting the workspace mode is: The last active mode that is not object-mode (`OB_MODE_OBJECT`) becomes the workspace mode. Therefore the workspace mode must never be `OB_MODE_OBJECT`
By default new workspace use edit-mode as workspace mode.

Now, some parts of the design I'm not sure yet. Mainly:
* The implementation makes the workspace remember if the workspace mode or `OB_MODE_OBJECT` is active. Pressing TAB toggles between them. However the workspace doesn't try to keep the workspace mode active while only using `OB_MODE_OBJECT` as fall-back or when the user explicitly sets it. This differes from what I wrote in [[https://developer.blender.org/T53389#474275|mentioned comment]]. Maybe that's better maybe not.
* If the workspace mode isn't compatible with the currently active object, pressing TAB does nothing. In theory this may make sense, in practice it might be quite annoying though.

I'm not submitting that for code review really. Just for feedback on the general design approach and the discussion points mentioned above.

Subscribers: sergey, dfelinto

Differential Revision: https://developer.blender.org/D2965

Commit Details:

Full Hash: a7172d399eb8a374f5bcca0e92937cf71bd6eb60
Parent Commits: 7c414bf, 9515737

Tehnyt: Miika HämäläinenViimeksi päivitetty: 07.11.2014 14:18 MiikaH:n Sivut a.k.a. MiikaHweb | 2003-2019