Blender Git Loki
Git Commits -> Revision c9cc03b
Revision c9cc03b by Julian Eisel (master) November 11, 2020, 18:07 (GMT) |
UI Code Quality: General refactor of Outliner View Layer display mode creation See https://developer.blender.org/D9499. * Turn functions into member functions (makes API for a type more obvious & local, allows implicitly sharing data through member variables, enables order independend definition of functions, allows more natural language for function names because of the obvious context). * Move important variables to classes rather than passing around all the time (shorter, more task-focused code, localizes important data names). * Add helper class for adding object children sub-trees (smaller, more focused units are easier to reason about, have higher coherence, better testability, can manage own resources easily with RAII). * Use C++ iterators over C-macros (arguably more readable, less macros is generally preferred) * Add doxygen groups (visually emphasizes the coherence of code sections, provide place for higher level comments on sections). * Prefer references over pointers for passing by reference (makes clear that NULL is not a valid value and that the current scope is not the owner). |
Commit Details:
Full Hash: c9cc03b688230d0b898467135e75e2cbac8a3226
Parent Commit: 249e4df
Lines Changed: +231, -158
4 Modified Paths:
/source/blender/editors/space_outliner/outliner_tree.c (+2, -1) (Diff)
/source/blender/editors/space_outliner/tree/tree_view.cc (+2, -2) (Diff)
/source/blender/editors/space_outliner/tree/tree_view.hh (+27, -3) (Diff)
/source/blender/editors/space_outliner/tree/tree_view_view_layer.cc (+200, -152) (Diff)
/source/blender/editors/space_outliner/tree/tree_view.cc (+2, -2) (Diff)
/source/blender/editors/space_outliner/tree/tree_view.hh (+27, -3) (Diff)
/source/blender/editors/space_outliner/tree/tree_view_view_layer.cc (+200, -152) (Diff)