Blender Git Loki

Git Commits -> Revision e20b315

Revision e20b315 by Philipp Oeser (master)
March 8, 2021, 14:18 (GMT)
Fix T86347: Add Primitive Tool fails for 1x1x1 scale

The Tool stores desired dimensions as `scale` and thus had to half the
scale again in `make_prim_init()` because by default all primitives are
created at a size of 2 in blender.

This worked, but:
- [1] it logged something like size=2, scale=2,2,2 for a 2x2x2 cube
[which does not sound right, it should be size=2 scale=1,1,1]
- [2] it had to make an exception for the case scale is exactly 1x1x1
[this happens when the property is not set specifically, e.g. adding
primitives from the menu]
-- this exception led to double sized primitives being created when the
tool asked for exact dimensions of 1x1x1

Now - instead of compensating in `make_prim_init()` - do this earlier in
the tool itself, see `view3d_interactive_add_modal`, this fixes the bug
and now also correctly logs size=2 scale 0.5,0.5,0.5 for a 1x1x1 cube.

Maniphest Tasks: T86347

Differential Revision: https://developer.blender.org/D10632

Commit Details:

Full Hash: e20b31504a2381011e60c5eadffb67f18918bc71
Parent Commit: 91825eb
Lines Changed: +4, -5

2 Modified Paths:

/source/blender/editors/mesh/editmesh_add.c (+2, -5) (Diff)
/source/blender/editors/space_view3d/view3d_placement.c (+2, -0) (Diff)
Tehnyt: Miika HämäläinenViimeksi päivitetty: 07.11.2014 14:18MiikaH:n Sivut a.k.a. MiikaHweb | 2003-2021