Blender Git Loki
Git Commits -> Revision e46c49f
Revision e46c49f by Sergey Sharybin (master) January 19, 2018, 10:12 (GMT) |
Fix T53788: Camera animation not working Both object level and camera datablock properties animation did not work with copy on write enabled. The root of the issue is going to the fact, that all interface elements are referencing original datablock. For example, View3D has pointer to camera it's using, and all areas which does access v3d->camera should in fact query for the evaluated version of that camera, within the current context. Annoying part of this change is that we now need to pass depsgraph in lots of places. Which is rather annoying. Alternative would be to cache evaluated camera in viewport itself, but then it makes it annoying to keep things in sync. Not sure if there is nicer solution here. Reviewers: dfelinto, campbellbarton, mont29 Subscribers: dragoneex Differential Revision: https://developer.blender.org/D3007 |
Commit Details:
Full Hash: e46c49ff3dd67c7d759b581b677b4ab90cee3c46
Parent Commit: 9cac97f
Lines Changed: +231, -129
38 Modified Paths:
/source/blender/blenkernel/BKE_camera.h (+2, -1) (Diff)
/source/blender/blenkernel/intern/camera.c (+5, -2) (Diff)
/source/blender/draw/engines/eevee/eevee_depth_of_field.c (+4, -2) (Diff)
/source/blender/draw/engines/eevee/eevee_motion_blur.c (+5, -3) (Diff)
/source/blender/draw/modes/object_mode.c (+10, -2) (Diff)
/source/blender/editors/armature/editarmature_sketch.c (+3, -2) (Diff)
/source/blender/editors/curve/editcurve_paint.c (+5, -1) (Diff)
/source/blender/editors/gpencil/drawgpencil.c (+2, -1) (Diff)
/source/blender/editors/gpencil/gpencil_convert.c (+2, -1) (Diff)
/source/blender/editors/gpencil/gpencil_paint.c (+13, -12) (Diff)
/source/blender/editors/gpencil/gpencil_utils.c (+1, -1) (Diff)
/source/blender/editors/include/ED_gpencil.h (+2, -0) (Diff)
/source/blender/editors/include/ED_mesh.h (+2, -0) (Diff)
/source/blender/editors/include/ED_view3d.h (+12, -4) (Diff)
/source/blender/editors/manipulator_library/manipulator_library_utils.c (+1, -1) (Diff)
/source/blender/editors/manipulator_library/manipulator_types/arrow3d_manipulator.c (+1, -0) (Diff)
/source/blender/editors/manipulator_library/manipulator_types/dial3d_manipulator.c (+4, -2) (Diff)
/source/blender/editors/mesh/editmesh_knife.c (+4, -3) (Diff)
/source/blender/editors/mesh/editmesh_polybuild.c (+1, -0) (Diff)
/source/blender/editors/mesh/editmesh_utils.c (+4, -2) (Diff)
/source/blender/editors/physics/particle_edit.c (+2, -1) (Diff)
/source/blender/editors/render/render_internal.c (+20, -11) (Diff)
/source/blender/editors/sculpt_paint/paint_image_proj.c (+4, -2) (Diff)
/source/blender/editors/sculpt_paint/sculpt.c (+1, -1) (Diff)
/source/blender/editors/space_view3d/view3d_draw.c (+25, -19) (Diff)
/source/blender/editors/space_view3d/view3d_draw_legacy.c (+23, -18) (Diff)
/source/blender/editors/space_view3d/view3d_edit.c (+17, -11) (Diff)
/source/blender/editors/space_view3d/view3d_fly.c (+4, -2) (Diff)
/source/blender/editors/space_view3d/view3d_intern.h (+5, -4) (Diff)
/source/blender/editors/space_view3d/view3d_manipulator_camera.c (+2, -1) (Diff)
/source/blender/editors/space_view3d/view3d_project.c (+9, -5) (Diff)
/source/blender/editors/space_view3d/view3d_view.c (+13, -7) (Diff)
/source/blender/editors/space_view3d/view3d_walk.c (+3, -1) (Diff)
/source/blender/editors/transform/transform.c (+3, -1) (Diff)
/source/blender/editors/transform/transform.h (+2, -0) (Diff)
/source/blender/editors/transform/transform_generics.c (+3, -1) (Diff)
/source/blender/editors/transform/transform_snap_object.c (+2, -0) (Diff)
/source/blender/windowmanager/intern/wm_draw.c (+10, -4) (Diff)
/source/blender/blenkernel/intern/camera.c (+5, -2) (Diff)
/source/blender/draw/engines/eevee/eevee_depth_of_field.c (+4, -2) (Diff)
/source/blender/draw/engines/eevee/eevee_motion_blur.c (+5, -3) (Diff)
/source/blender/draw/modes/object_mode.c (+10, -2) (Diff)
/source/blender/editors/armature/editarmature_sketch.c (+3, -2) (Diff)
/source/blender/editors/curve/editcurve_paint.c (+5, -1) (Diff)
/source/blender/editors/gpencil/drawgpencil.c (+2, -1) (Diff)
/source/blender/editors/gpencil/gpencil_convert.c (+2, -1) (Diff)
/source/blender/editors/gpencil/gpencil_paint.c (+13, -12) (Diff)
/source/blender/editors/gpencil/gpencil_utils.c (+1, -1) (Diff)
/source/blender/editors/include/ED_gpencil.h (+2, -0) (Diff)
/source/blender/editors/include/ED_mesh.h (+2, -0) (Diff)
/source/blender/editors/include/ED_view3d.h (+12, -4) (Diff)
/source/blender/editors/manipulator_library/manipulator_library_utils.c (+1, -1) (Diff)
/source/blender/editors/manipulator_library/manipulator_types/arrow3d_manipulator.c (+1, -0) (Diff)
/source/blender/editors/manipulator_library/manipulator_types/dial3d_manipulator.c (+4, -2) (Diff)
/source/blender/editors/mesh/editmesh_knife.c (+4, -3) (Diff)
/source/blender/editors/mesh/editmesh_polybuild.c (+1, -0) (Diff)
/source/blender/editors/mesh/editmesh_utils.c (+4, -2) (Diff)
/source/blender/editors/physics/particle_edit.c (+2, -1) (Diff)
/source/blender/editors/render/render_internal.c (+20, -11) (Diff)
/source/blender/editors/sculpt_paint/paint_image_proj.c (+4, -2) (Diff)
/source/blender/editors/sculpt_paint/sculpt.c (+1, -1) (Diff)
/source/blender/editors/space_view3d/view3d_draw.c (+25, -19) (Diff)
/source/blender/editors/space_view3d/view3d_draw_legacy.c (+23, -18) (Diff)
/source/blender/editors/space_view3d/view3d_edit.c (+17, -11) (Diff)
/source/blender/editors/space_view3d/view3d_fly.c (+4, -2) (Diff)
/source/blender/editors/space_view3d/view3d_intern.h (+5, -4) (Diff)
/source/blender/editors/space_view3d/view3d_manipulator_camera.c (+2, -1) (Diff)
/source/blender/editors/space_view3d/view3d_project.c (+9, -5) (Diff)
/source/blender/editors/space_view3d/view3d_view.c (+13, -7) (Diff)
/source/blender/editors/space_view3d/view3d_walk.c (+3, -1) (Diff)
/source/blender/editors/transform/transform.c (+3, -1) (Diff)
/source/blender/editors/transform/transform.h (+2, -0) (Diff)
/source/blender/editors/transform/transform_generics.c (+3, -1) (Diff)
/source/blender/editors/transform/transform_snap_object.c (+2, -0) (Diff)
/source/blender/windowmanager/intern/wm_draw.c (+10, -4) (Diff)
Master Commits
MiikaH:n Sivut a.k.a. MiikaHweb | 2003-2021