Blender Git Loki
Git Commits -> Revision e6cdee3
Revision e6cdee3 by Sergey Sharybin (master) March 12, 2013, 16:57 (GMT) |
Patch #34204: [Render Animation] Fails with "Error: Specified sample_fmt is not supported" with ogg vorbis Patch by Jehan Pages (pardon for mis-typing, emacs-nox works not so good with urf-8 buffers here), with some own modifications. Thanks! From the patch tracker: The problem is because of several versions of ffmpeg, but even more because of the fork situation libav/ffmpeg. So there are some installed versions out there where you *must* use a float sample for some codec; whereas oppositely on some other installations, you *must* use the int sample. So for some people, one works not the other, and reciprocally. As a consequence, you can't just have a switch codec-based, like in current code, which decides on the float or int implementation, you must necessarily have a runtime test because you won't know until then if ogg vorbis will use one or another sample (note: that's true also for AC3 as I fixed the exact same bug in DVDStyler for AC3 encoding a few months ago; and I guess it would be same for AAC). Some notes from self: - New FFmpeg requires using FLTP for AAC, AC3 and Vorbis, it's not supported by audaspace and result in this case would be just wrong. Throw an error in cases FLTP is trying to be used. - Moved strict_std_compliance a bit upper. When we'll support FLTP both FLT and FLTP for AAC would need to be using FF_COMPLIANCE_EXPERIMENTAL. - It is nice to have such check of supported by codec formats anyway. |
Commit Details:
Full Hash: e6cdee370e74ef3e48051ad95a4bc3eba5f804c4
SVN Revision: 55220
Parent Commit: d0af110
Lines Changed: +44, -4
1 Modified Path:
/source/blender/blenkernel/intern/writeffmpeg.c (+44, -4) (Diff)