Blender Git Loki
Git Commits -> Revision ef9269b
Revision ef9269b by Campbell Barton (master) October 19, 2021, 23:31 (GMT) |
Thumbnails: refactor extraction to use one code-path for all platforms Thumbnail extraction now shares code between Linux/Windows, allowing thumbnails from Zstd compressed blend files to be extracted. The main logic is placed in blendthumb_extract.cc and is built as static library. For windows there is DLL which is registered during blender install and which then reads and generates thumbnails. For other platforms there is blender-thumbnailer executable file which takes blend file as an input and generates PNG file. As a result Python script blender-thumbnailer.py is no longer needed. The thumbnail extractor shares the same code-path as Blenders file reading, so there is no need to duplicate any file reading logic. This means reading compressed blend files is supported (broken since the recent move Zstd compression - D5799). This resolves T63736. Contributors: - @alausic original patch. - @LazyDodo windows fixes/support. - @campbellbarton general fixes/update. - @lukasstockner97 Zstd support. Reviewed By: sybren, mont29, LazyDodo, campbellbarton Ref D6408 |
Commit Details:
Full Hash: ef9269bd62f31e39d39cc59cd34354b53eae6661
Parent Commit: bca2701
Lines Changed: +1207, -859
8 Added Paths:
/source/blender/blendthumb/src/blender_thumbnailer.cc (+113, -0) (View)
/source/blender/blendthumb/src/blendthumb.hh (+65, -0) (View)
/source/blender/blendthumb/src/blendthumb_extract.cc (+257, -0) (View)
/source/blender/blendthumb/src/blendthumb_png.cc (+158, -0) (View)
/source/blender/blendthumb/src/blendthumb_win32.cc (+237, -0) (View)
/source/blender/blendthumb/src/blendthumb_win32.def (+5, -0) (View)
/source/blender/blendthumb/src/blendthumb_win32.rc (+26, -0) (View)
/source/blender/blendthumb/src/blendthumb_win32_dll.cc (+293, -0) (View)
/source/blender/blendthumb/src/blendthumb.hh (+65, -0) (View)
/source/blender/blendthumb/src/blendthumb_extract.cc (+257, -0) (View)
/source/blender/blendthumb/src/blendthumb_png.cc (+158, -0) (View)
/source/blender/blendthumb/src/blendthumb_win32.cc (+237, -0) (View)
/source/blender/blendthumb/src/blendthumb_win32.def (+5, -0) (View)
/source/blender/blendthumb/src/blendthumb_win32.rc (+26, -0) (View)
/source/blender/blendthumb/src/blendthumb_win32_dll.cc (+293, -0) (View)
5 Deleted Paths:
/release/bin/blender-thumbnailer.py (+0, -193)
/source/blender/blendthumb/src/BlenderThumb.cpp (+0, -321)
/source/blender/blendthumb/src/BlendThumb.def (+0, -5)
/source/blender/blendthumb/src/BlendThumb.rc (+0, -26)
/source/blender/blendthumb/src/Dll.cpp (+0, -293)
/source/blender/blendthumb/src/BlenderThumb.cpp (+0, -321)
/source/blender/blendthumb/src/BlendThumb.def (+0, -5)
/source/blender/blendthumb/src/BlendThumb.rc (+0, -26)
/source/blender/blendthumb/src/Dll.cpp (+0, -293)