Blender Git Loki
Git Commits -> Revision f00cb93
Revision f00cb93 by Philipp Oeser (master) September 3, 2020, 13:01 (GMT) |
Fix T63125: Gpencil: bones cannot be selected in weightpaint mode Some underlying functionality was not ready for greasepencil: - BKE_modifiers_get_virtual_modifierlist (now introduce dedicated BKE_gpencil_modifiers_get_virtual_modifierlist) - BKE_modifiers_is_deformed_by_armature - checks in drawing code - checks in (pose) selection code A couple of changes to make this work: - `eGpencilModifierType_Armature` has to be respected (not only `eModifierType_Armature`) - `OB_MODE_WEIGHT_GPENCIL` has to be respected (not only `OB_MODE_WEIGHT_PAINT`) -- (now use new `OB_MODE_ALL_WEIGHT_PAINT`) - `gpencil_weightmode_toggle_exec` now shares functionality from `wpaint_mode_toggle_exec` -- moved to new `ED_object_posemode_set_for_weight_paint` This patch will also set the context member "weight_paint_object" for greasepencil (otherwise some appropriate pose operators wont work when in weightpaint mode) Reviewed By: campbellbarton Maniphest Tasks: T63125 Differential Revision: https://developer.blender.org/D8483 |
Commit Details:
Full Hash: f00cb93dbec7bf5dc05302c868f20fcd5aed7db7
Parent Commit: a505a85
Committed By: Philipp Oeser
Lines Changed: +261, -91
16 Modified Paths:
/source/blender/blenkernel/BKE_gpencil_modifier.h (+8, -0) (Diff)
/source/blender/blenkernel/intern/gpencil_modifier.c (+49, -0) (Diff)
/source/blender/blenkernel/intern/modifier.c (+40, -16) (Diff)
/source/blender/draw/engines/overlay/overlay_armature.c (+3, -3) (Diff)
/source/blender/draw/intern/draw_manager.c (+1, -1) (Diff)
/source/blender/editors/armature/pose_select.c (+37, -13) (Diff)
/source/blender/editors/gpencil/gpencil_edit.c (+9, -0) (Diff)
/source/blender/editors/include/ED_object.h (+5, -0) (Diff)
/source/blender/editors/object/object_modes.c (+72, -0) (Diff)
/source/blender/editors/screen/screen_context.c (+1, -1) (Diff)
/source/blender/editors/screen/screen_ops.c (+1, -1) (Diff)
/source/blender/editors/sculpt_paint/paint_vertex.c (+2, -44) (Diff)
/source/blender/editors/space_view3d/view3d_select.c (+2, -2) (Diff)
/source/blender/editors/space_view3d/view3d_view.c (+27, -10) (Diff)
/source/blender/makesdna/DNA_gpencil_modifier_types.h (+1, -0) (Diff)
/source/blender/makesdna/DNA_object_enums.h (+3, -0) (Diff)
/source/blender/blenkernel/intern/gpencil_modifier.c (+49, -0) (Diff)
/source/blender/blenkernel/intern/modifier.c (+40, -16) (Diff)
/source/blender/draw/engines/overlay/overlay_armature.c (+3, -3) (Diff)
/source/blender/draw/intern/draw_manager.c (+1, -1) (Diff)
/source/blender/editors/armature/pose_select.c (+37, -13) (Diff)
/source/blender/editors/gpencil/gpencil_edit.c (+9, -0) (Diff)
/source/blender/editors/include/ED_object.h (+5, -0) (Diff)
/source/blender/editors/object/object_modes.c (+72, -0) (Diff)
/source/blender/editors/screen/screen_context.c (+1, -1) (Diff)
/source/blender/editors/screen/screen_ops.c (+1, -1) (Diff)
/source/blender/editors/sculpt_paint/paint_vertex.c (+2, -44) (Diff)
/source/blender/editors/space_view3d/view3d_select.c (+2, -2) (Diff)
/source/blender/editors/space_view3d/view3d_view.c (+27, -10) (Diff)
/source/blender/makesdna/DNA_gpencil_modifier_types.h (+1, -0) (Diff)
/source/blender/makesdna/DNA_object_enums.h (+3, -0) (Diff)