Blender Git Loki
Git Commits -> Revision f3fb1df
Revision f3fb1df by Philipp Oeser (master) March 5, 2021, 11:50 (GMT) |
Fix T86293: crash undoing after executing the python console in certain scenarios In general, I could not find a reason executing from the python console should not do an Undo push. Running a script from the Text Editor does this as well and this seems generally useful. Without an Undo push, one can easily run into situations were IDs have been added or removed and undo on would then cause trouble (e.g. first selection then bpy.ops.object.duplicate() -- this crashed as reported in T86293 -- duplicate does not get its own undo push because it is not the last op in the list, wm->op_undo_depth is not zero). This has changed with the Undo refactor, so in essence the root cause is the same as T77557, Legacy Undo does not suffer from the crash (but misses the generally useful undo push from the console still) Now add Undo to CONSOLE_OT_execute bl_options ('UNDO_GROUPED' seems more appropriate than plain 'UNDO' since pasting multiple lines of code will call CONSOLE_OT_execute multiple times in a row). Maniphest Tasks: T86293 Differential Revision: https://developer.blender.org/D10625 |
Commit Details:
Full Hash: f3fb1df1922a938272a84209c55206255c687e31
Parent Commit: 5668901
Lines Changed: +1, -0
1 Modified Path:
/release/scripts/startup/bl_operators/console.py (+1, -0) (Diff)