Blender Git Loki

Git Commits -> Revision fa59346

Revision fa59346 by Jacques Lucke (master)
May 3, 2019, 11:05 (GMT)
Refactor: Support arbitrary y offset for channel list

At first you could think that this refactor would not be
necessary, because `ACHANNEL_FIRST` exists already.
It contained the small y offset that all channels had.

Unfortunately, a lot of code assumed that
`ACHANNEL_FIRST = -ACHANNEL_HEIGHT`, making the
define pretty much useless. This refactor fixes that
for the action and nla editor.

As a nice side effect, this patch fixes channel box select.
Before there was always have a half-channel offset.

Reviewers: brecht

Differential Revision: https://developer.blender.org/D4783

Commit Details:

Full Hash: fa59346c1340da4189e5c7d38164a74dc096db10
Parent Commit: b5eb654
Lines Changed: +162, -415

12 Modified Paths:

/source/blender/editors/animation/anim_channels_edit.c (+17, -33) (Diff)
/source/blender/editors/include/ED_anim_api.h (+8, -5) (Diff)
/source/blender/editors/include/UI_view2d.h (+1, -19) (Diff)
/source/blender/editors/interface/view2d.c (+15, -125) (Diff)
/source/blender/editors/space_action/action_draw.c (+44, -93) (Diff)
/source/blender/editors/space_action/action_edit.c (+4, -8) (Diff)
/source/blender/editors/space_action/action_select.c (+10, -14) (Diff)
/source/blender/editors/space_graph/graph_draw.c (+16, -32) (Diff)
/source/blender/editors/space_nla/nla_channels.c (+3, -10) (Diff)
/source/blender/editors/space_nla/nla_draw.c (+38, -58) (Diff)
/source/blender/editors/space_nla/nla_edit.c (+4, -9) (Diff)
/source/blender/editors/space_nla/nla_select.c (+2, -9) (Diff)
Tehnyt: Miika HämäläinenViimeksi päivitetty: 07.11.2014 14:18MiikaH:n Sivut a.k.a. MiikaHweb | 2003-2021