Blender Git Loki

Cycles X: Switch PassAccessor to BufferPass

Moving towards pixels access from only Buffers, without access to
the scene graph.

Should be no functional changes.

Cycles X: restore support for render progress bar percentage

Merge branch 'master' into cycles-x

Cycles X: Switch startswith/endswith to string_view

Currently no functional changes. Making this internal API flexible to
be used for any string-like objects.

The implementation is a bit lower-level than one would expect from the
C++'s string_view. This is because the string_view implementation is
coming from OIIO./

Differential Revision: https://developer.blender.org/D12483

Cycles X: Cover string startswith/endswith with tests

Cleanup: remove unnecessary clamp, is already done when initializing closure

Fix deadlock due to lock order inversion in rendering after GPU display changes

Main thread:
* Acquires DST.gl_context_mutex lock for drawing image editor
* Acquires mutex_ in GPUDisplay::draw()

Render thread:
* Acquires mutex_ in GPUDisplay::update_begin()
* Acquires DST.gl_context_mutex for updating texture

Ideally DST.gl_context_mutex would not be needed at all, for best performance.
But this requires deep changes to the draw manager since it relies on global
variables in many places.

Instead rely on DST.gl_context_mutex for mutual exclusion between update and
draw operations in the subclass, and only use mutex_ for thread safe access to
the parameters.

Differential Revision: https://developer.blender.org/D12468

Fix using reference to a temporary variable in Cycles X

Cycles X: Convert pass fields to socket declarations

No functional changes, just finalizes conversion of Pass to a proper
scene node.

Differential Revision: https://developer.blender.org/D12433

Fix memory leak in Cycles X

Caused by recent refactor of tile file storage: need to take care of
freeing pass nodes.

Merge branch 'master' into cycles-x

Fix too small step size for time limit button, increase from 1ms to 1s

Cleanup: Unused function

No functional changes.

Cycles X: Store passes and buffer params in tile file metadata

Allows to fully forget about passes and parameters once the file
was fully written.

Currently should be no functional changes. Will be used when a proper
memory saving is implemented: when EXR files are read from disk and
written to Blender after all view layers were rendered.

Is debatable why we need to store actual passes: for now it was the
most local change to move towards the goal (which is to decouple
full buffers reading from the Session/PathTrace/TileManager state).
Might end up storing simplified version of passes in the BufferParams
so that we can use `get_render_tile_pixels()` without having Scene
and only relying on the RenderBuffers. In any case, we would need to
store some sort of metadata, and whether it comes to/from passes is
something we can tweak in the future.

Differential Revision: https://developer.blender.org/D12447

Merge branch 'master' into cycles-x

Fix crash denoising shadow catcher in Cycles X

Fix missing render progress on Windows in Cycles X

The issue is caused by `::wglShareLists()` returning an error if the
shared context is currently in use, so that the OpenGL context for
GPUDisplay did fail to be created.

After a lot of experimentation all the non-intrusive changes to support
OpenGL context creation with shared textures has failed.

The easiest way to have reliable OpenGL context creation is to do it on
the main thread.

For the offline rendering this is done in the pipeline.c. This change
takes advantage of this and uses the Render::gl_context for the GPU
display implementation for offline rendering.

For the viewport rendering we don't have Render, but the engine is
created from the main thread, so we can create context from the Cycles
side.

Not really happy with such approach, but this seems to be easiest and
safest way to go for now to get other bits of Cycles X finished. In the
future Vulkan should make things easier for the context creation and
multi-threaded applications.

Differential Revision: https://developer.blender.org/D12439

Merge branch 'master' into cycles-x

Fix error in last random walk bugfix

Fix T90010: Cycles X random walk discontinuity between low and zero albedo