Blender Git Loki

Merge branch 'master' into blender2.8

Merge branch 'master' into blender2.8

Cleanup: warning

Cleanup: move 3D view utilities into own file

Operators and utility functions were getting too mixed up,
the files were also quite large.

Fix T53914: Volumetric scattering now goes correctly through transparent surfaces.

There was a check for volume bounces at every surface intersection. That could lead to a volume scattered path being terminated
when passing through a transparent surface. This check was superfluous, as the volume shader evaluation already checks the
number of volume bounces and once it passes the max, volume shaders will not return scatter events any more.

Reviewers: #cycles, brecht

Reviewed By: #cycles, brecht

Subscribers: brecht, #cycles

Tags: #cycles

Maniphest Tasks: T53914

Differential Revision: https://developer.blender.org/D3024

Speed up a little drawing of UVs in the Image Editor

In my tests the previous loop was running in 200 ms. With this change it now runs in 17 ms.

The difference in the end is still not great because the `draw_uvs_lineloop_bmface` function is called for each face and has an ImmBegin and ImmEnd in the function itself

Code refactor: make mixed small/large BSSRDF radii more robust.

Collections: As it turned out, this is quite harmless to have accessible everwhere

I think ultimately we may move these operators from the outliner space to scene.

Partial revert of a08f687b91a2a7880889.

Make outliner new collection operator work via viewport too

Technically this revert b3bcbc9e85aa. This however doesn't seem to be needed
any longer.

Outliner: If a collection is empty and you drag something inside it, it opens up.

Idea by Pablo Vazquez.

Fix mixed BSDF + BSSRDF sampling bug in path tracing, after 095a01a73a35.

Spotted by Ha Hyung-jin, thanks!

Code refactor: store RGB BSSRDF in a single closure.

Previously we stored each color channel in a single closure, which was
convenient for sampling a closure and channel together. But this doesn't
work so well for algorithms where we want to render multiple color
channels together.

IMB: Add asserts that returned fps and fps base are strictly positives.

Forgot to add that in previous commit, also related to T53003.

Related to T53003: tweak scene fps range.

Move restricted 'reasonable' range to ui_range, and allow wider values
for manual settings.

Fix T53003: IMB: Invalid framerate handling due to short integer overflow.

FFMPEG uses int for the numerator, while Blender uses a short. So in
cases people gave weird exotic framerate values and we cannot reduce
enough the numerator, we'd get totally weird values (even negative frame
rates sometimes!)

Now we add checks for short overflow and approximate as best as possible
in that case (error should not matter unless you have shots of at least
several hundreds of hours ;) ).

fix:T53271 now using the context scene layer as requested

Fix Collada importer (crash)

We were not tagging depsgraph to update its nodes after importing new objects.

Make object_update comment about lack of ID even more clear

Fix silly crash on Collada

Note: This was originally wrongly committed together with an outliner tooltip
fix, re-committing separately now. See bd7060a87fd9.

Outliner tooltips: Small refactor, future proof change

In the future we may have siblings to collections (like overrides) that are not
collections. This change make sure tooltips will keep working.

Note: This was originally wrongly committed together with a Collada fix,
re-committing separately now. See bd7060a87fd9.