Blender Git Loki

GPencil: Cleanup more comments (cont)

Clang-Tidy: Enable redundant static qualifier warning

This change enables readability-static-definition-in-anonymous-namespace
warning in .clang-tidy configuration.

Move bSound cache handling during undo to new system.

Cleanup: do not use magic values for enums...

New undo cache management: Add Image IDs.

Some notes:
* `Image.cache` acts as some kind of 'main' cache, when it is NULL
(could not be restored), other caches should also be cleared. Oddly
enough, previous code was not clearing **all** caches, could not find
any reason for that behavior, so new code does a full clear.
* `imamap` is still used for Node previews from scenes' compositor,
however this is actually fully disabled in `direct_link_node()`.
* For render slots we cannot use offsetof as third part of the cache
key, so we are using a hash of the slot's name instead.

As far as I can tell, this fixes T76989: Visual glitches when undo after
reload multiple images by script (in Material Preview).

Readfile/Undo: initial refactor of cache preservation code.

Main goal here is to have better specificity using cache keys, to avoid
same memroy address being re-used messing up with cache pointers
restoration after undo had to re-read a data-block.

Once all caches handling are ported to this new system, it should fix
random issues like the one reported in T76989.

Part of D8183, refactoring how we preserve caches across undo steps in
readfile code.

IDTypeInfo: add new callback to loop over all cache pointers of an ID.

Part of D8183, refactoring how we preserve caches across undo steps in
readfile code.

Add key structure and hashing utils for ID caches.

Part of D8183, refactoring how we preserve caches across undo steps in
readfile code.

GPencil: Cleanup more comments (cont)

GPencil: Cleanup more comments (cont)

Cycles: rename viewport denoise Fastest option to Automatic and extend tooltip

Clang-tidy: Enable bugprone-lambda-function-name warning

Depsgraph: Use C++ style of guarded allocation of objects

Guarded allocator: Override placement new operator

Allows to in-place construct objects which are using guarded allocator.

GPencil: Cleanup move functions to geom from modifier

GPencil: Cleanup Doxygen comments (cont)

Cleanup: Fluid renaming from old 'manta' naming to new 'fluid' naming

Changed variable names from mmd, mds, mfs, and mes to fmd, fds, ffs, and fes. The author of this commits lights a candle for all the merge conflicts this will cause.

GPencil: Cleanup Doxygen comments

Cycles: Use TBB's spin mutex

First benefit is reduced boilerplate code.

Second benefit is fixed warnings about using deprecated spin lock
on macOS when using SDK 10.12 and above.

Differential Revision: https://developer.blender.org/D8182

BLI: Use TBB spin_mutex as SpinLock implementation

When building without TBB use native to the platform spin lock
implementation. For Windows it is an atomic-based busy-wait,
for Linux it is pthreads' spin lock.

For macOS it is a mutex lock. The reason behind this is to stop
using atomics library which has been declared deprecated in SDK
version 10.12. So this changes fixes a lot of noisy warnings on
the newer SDK.

Differential Revision: https://developer.blender.org/D8180