Blender Git Loki

Sculpt-dev: fix broken vcol attr
auto-creation

* Fixed BKE_sculpt_color_layer_create_if_needed
* Also fixed BKE_id_attribute_active_color_set,
accidentally pasted the getter's precondition.

Sculpt-dev: fix another crash

Sculpt-dev: fix gcc compile error

Sculpt-dev: fix crash

* Tool slots weren't initializes sculpt
brushes properly.

Sculpt-dev: improve uv smooth brush a bit

Sculpt-dev: SCULPT_reproject_cdata fixes

* SCULPT_reproject_cdata now forcibly re-snaps
for non-boundary loops.
* Also fixed a wrong radial loop iterator.

Sculpt-dev: dyntopo now detects uv island
boundaries, independently of
edge seams.

sculpt-dev: remove debug ATTR_NO_OPTS

* Sculpt-dev: pbvh draw cleanup

* PBVH drawing for eevee is now used for
PBVH_FACES as well as PBVH_BMESH.
* PBVH_FACES now uses pbvh draw for eevee rendering
* Refactored gpu_pbvh_gpu_make_vcol_offs into a
more general gpu_pbvh_gpu_make_attr_offs.
This should be a usable alternative to using a generic
attribute gpu system (whether the one that's #ifdef'd out
in gpu_buffers.c, or the new one that hit master
recently).
* Textured workbench draw mode now works for pbvh drawing.
* Fixed nasty stack overflow in dyntopo edge collapse.

Sculpt-dev: run clang-format on a few files

Sculpt-dev: fix pbvh draw getting gpu format
out of sync.

GPU_pbvh_update_attribute_names now returns a bool
if the format has changed.

Sculpt-dev: fix bug in last commit

Sculpt-dev: cross-module ref cleanup

* Removed a bunch of nasty editors->blenkernel
dependencies (2 still remain).
* Fixed a few bugs in last commit.

Sculpt-dev: sculpt colors stuff

* Mask by color now works for dyntopo.
* Attribute and vertex color lists in the UI
now hide temporary CD layers.
* Added a specific op for removing vertex color
attributes.
* Fixed various bugs.

Sculpt-dev: Add support for attribute triplets

It simply wasn't maintainable to store active/render
vertex color layer as integer indices into the
global attribute list. Making that work would've
required a great deal of boilerplate that would
have to be inserted in lots of places. There
is simply no justification for doing that.

Instead, I've coded an AttributeRef struct that
simply stores a (type, name, domain) triplet to
uniquely reference an attribute layer.

This will be submitted as a patch for master
too.

Sculpt-dev: fix compile error

Sculpt-dev: fix crash

Remove debug ATTR_NO_OPT

Sculpt-dev: fix brush input mapping inheritance

* Brush input mappings now have three
inheritance mode: "always", "never" and
"channel" (use channel's inheritance mode).
* Note that the UI exposes a single inherit icon,
which just toggles between "always" and
"never," to lessen user confusion.
* Brush mappings default to "never" inheritance
mode.
* Fixed wrong node update flag in bke_pbvh_insert_face_finalize
leading to disappearing parts of the mesh.

Sculpt-dev: add icons for twist and multires
displacement smear.