Blender Git Loki

Merge branch 'master' into sculpt-dev

Sculpt-dev: expose a few cloth settings for cloth
deform target in bounday/pose brushes.

Sculpt: fix twist brush mirroring

Sculpt-dev: fix memory corruption

* Forgot to change the face area
customdata layer to CD_FLOAT2 everywhere,
leading to nasty memory corruption.

Sculpt-dev: fix elastic deform brush

* Volume preservation had wrong bounds in
elastic deform brush leading to wrong
behavior.
* Fixed unprojected_radius channel not
being shown in header when scene radius
unit is on.
* Draw face sets now only fully rebuild draw buffers
in indexed draw modes that require it.

Sculpt-dev: fix memory corruption

Sculpt-dev: Fix color filter not auto
creating a color layer.

* This is probably something I broke.
There was a SCULPT_has_colors() call that
wasn't needed.

Sculpt-dev: fix memory corruption

Sculpt-dev: fix broken color filter, alpha
was being set to garbage value.

Sculpt-dev: fix thread contention
in weighted smooth
* Cached face areas are now updated
in a double buffered fashion;
all threads read from one side of
the buffer while the other is written
to by the threads that own a given
face; the buffers are swapped on
each iteration of a tool that uses
face areas.
* Fixes smooth flickering.

Sculpt-dev: support area weighted smooth for PBVH_FACES

* This was actually kind of annoying; the
vertex->face-area-list code is in pbvh and
relies on edge ordering
around verts, but that order is non-trivial for
PBVH_FACES (relying as it does on a vertex->poly
map). This ordering was calculated entirely in
editors/sculpt_paint/sculpt.c, not callable from
pbvh.
* The solution was to add a helper function to pbvh
for building vertex->edge lists from vertex->poly
maps. This is then used by both sculpt.c and the
vertex->face-area-list code.

* Also improved boundary bevel smooth a bit. I'm
thinking of extracting it from SCULPT_neighbor_coords_average_interior
into its own function and possibly its own brush.

Sculpt-dev: fix corruption in dyntopo
fast pbvh leaf builder callback.

Sculpt-dev: don't show input mapping
settings in sculpt context menu

Sculpt-dev: Add brush_eval field to Paint

* Paint now has a brush_eval field which
is used in leu of ->brush if non-null.
* This lets us get rid of all the annoying:
`brush = ss->cache ? ss->cache->brush : BKE_paint_brush`
code. Now it's just BKE_paint_brush.
* Used by SCULPT_run_command.
* Also fixed nasty scene spacing bug.

Sculpt-dev: fix multires crash in last commit

Sculpt-dev: bugfixes

* Fixed PBVH_FACES vcol draw bug.
* Fixed boundary smooth being turned on
if its temp customdata layer exists.
* Fixed unnesting of brush panels from
last commit improperly showing up
in the workspace tab for sculpt
instead of the brush tab.

Sculpt-dev: sculpt_init_tool_override_channels
related fixes

Various fixes so sculpt_init_tool_override_channels
for shift-smooth can replicate the prior behavior:

* Brush spacing will now look up brush channel
spacing directly for sculpt, instead of relying
on copying the channel data into Brush.
* Brush spacing code will now use brush channel
pressure for sculpt. Fixes broken shift-smooth
pen pressure.
* The falloff_curve channel is now automatically
added (before it was only used internally by
command lists, the code was defaulting to
the Brush field otherwise).
* BrushCurve now has an option for custom curve
presets to have negative slopes.
* The Falloff panel now puts the type dropbox
inside the panel header.
* Falloff panel also now uses brush channel data in
sculpt mode.
* falloff_shape is now a brush channel

In a somewhat unrelated change, I also unnested the
Brush Settings subpanels. It's been driving me
insane for a very, very long time. Much more
usable this way.

Sculpt-dev: fix smooth_strength_factor bug

* Fixed bug where BRUSH_MAPPING_INHERIT was
being or'd to BrushMapping->flag instead
of assigned to ->inherit_mode.
* Fixed smooth_strength_factor
and smooth_strength_projection.
* Also added yet more asan poisoning to mempool
* Added a function to build final inherited brush
channel, BKE_brush_channel_copy_final_data. Takes
BrushMapping->inherit_mode into account.

Sculpt-dev: undo debug disabling of threads for
color filter.

Sculpt-dev: add random_[hue/sat/value]
color filter options from
sculpt-mode-features

* Follows comment in mesh filter's randomize and
uses BLI_hash_int_3d.
* Added a seed parameter.
* Also renamed SCULPT_get_mdyntopo to SCULPT_get_sculptvert.