Blender Git Loki

Cleanup - Remove direct BKE_gpencil_batch_cache_dirty() code in favor of depsgraph tagging

Cleanup: Eliminate BKE_gpencil_batch_cache_alldirty()

This accessed the global G.main directly, which we're trying to remove

Fix: Version patching code was creating extra GP datablocks and throwing them away

After modifying the BKE_object_add() function to create a new GP datablock
by default, this change in behaviour would cause problems for the version
patching code fixing the old scene->gpd.

Cleanup - Remove unused var

Cleanup - Style

Cleanup: Remove the redundant GP_TOOL_SOURCE_OBJECT stuff

Since we only have GP objects in the 3D view now, this is the only
setting that should be used. Therefore, there's no need to set this
setting or check if for any reasons anymore.

Cleanup: Use standard logic for duplicating OB_GPENCIL objects and their data

Fix: GP objects should get created with GP datablocks initialised already
(just like all other object types)

Previously, because the GP datablock was stored in a different place,
this had to be handled differently from other datablocks. But that
doesn't hold anymore, so it's time to fix that.

Make BKE_gpencil_data_addnew() accept Main as an argument instead of using G.main

Fix: Remove temporary debugging prints

Fix: Remove most of the code for treating GP as a special case in the vertex group poll functions

These were causing crashes on GP datablocks with ob->data not set
when clicking on the Vertex Groups panel (i.e. as the operator lookups
would cause problems)

Fix typo causing crashes when trying to draw GP objects

Fix: Properties Editor was still showing the datablock selector for the old Object.grease_pencil

Fix: Some more sanity checks for cases not handled

Fix crashes on startup

Fix some missed ob->gpd references

Fix typos and crash on startup

GP Branch: Use ob->data instead of ob->gpd for storing GP object's GPencil datablock

WARNING: Old files created in the GP branch may break after this commit!

* There won't be data loss, but it will be necessary to manually fix this
per-file as needed. The old ob->gpd pointer remains for now to ease the
transition.

* The code will attempt to version patch old files that store data in this
pointer. However, right now, this only works for GP Objects and for Empties.

WIP Temporarily knock out some of the bad modifier/update hacks being used

These will hopefully be removed after some more testing, but in the meantime,
just commenting them out to test if things work still.

Hacky WIP code to verify that GPencil-Dopesheet Integration (for modifiers) is working

This code should be replaced, as it currently just duplicates the
modifier-looping logic (bad!). However, this is just a temporary placeholder
needed to get the updateDepsgraph() calls to run at all.

In any case, this would've been easier if I'd done the ob->gpd ==> ob->data
fixes first, since this hack wouldn't be needed.