Blender Git Loki

VSE: Fix of several outline and handle related problems by bracket handles

There are numerous problems with the current handles and outlines:
- Current handles are making waveform editing imprecise: T90824
- They are not showing a direction(previously they had arrows).
- Having both strip(via outline) and handles selection drawn is the cause of confusion: T90843
- Strip overlay texts are stealing attention away from with the selected elements.
- Adjoined outlines are drawn op top of each other.

Solutions:
- Change handles to bracket shaped(introduced in: D10297), so the waveform is not covered by the handle.
- Selection is drawn as either handle or strip, so there is no confusion(and it is in consistency with ex. 3d view where a selected object and a selected vertex are drawn at the same time).
- Since the handles are smaller this way, the overlay and transform texts colors are muted a bit, so selection will stand out as the most highlighted elements.
- The outlines have been tweaked, so the outlines are moved away from each other and a dark line is separating them.

Before
{F10768098,size=full}

After
{F10768103,size=full}

A gif:
{F10768170,size=full}

Differential Revision: https://developer.blender.org/D12308

added missing comment

Fixed problems with target_attribute was null

Fix field type in curve resample node

Fix T91725: Waveforms are not displayed

Use `sseq->timeline_overlay.flag` for `SEQ_TIMELINE_ALL_WAVEFORMS`
instead of `sseq->flag`.

Fix T91920: Missing decorate buttons in sound panel

Add back decorate buttons, move mono and display waveforms to bottom as
they were before.

Merge branch 'master' into soc-2021-porting-modifiers-to-nodes-merge-by-distance

# Conflicts:
# source/blender/blenkernel/BKE_node.h

Cleanup: Use LISTBASE_FOREACH macro

Make keyframe inserts/removals less verbose when called from python.

Following operators now only report messages back when they are called via their invoke-methods:

- ANIM_OT_keyframe_insert
- ANIM_OT_keyframe_insert_by_name
- ANIM_OT_keyframe_insert_menu
- ANIM_OT_keyframe_delete
- ANIM_OT_keyframe_clear_v3d
- ANIM_OT_keyframe_delete_v3d

Also removed the attribute confirm_success from the following operators:

- ANIM_OT_keyframe_insert
- ANIM_OT_keyframe_insert_by_name
- ANIM_OT_keyframe_insert_menu
- ANIM_OT_keyframe_delete
- ANIM_OT_keyframe_delete_by_name

Note: addons/scripts possibly need to be updated if they use the above operators AND set the "confirm_success" attribute

Reviewed By: campbellbarton

Differential Revision: https://developer.blender.org/D12697

Remove dangling include

Fix gcc compile errors

Sculpt: Fix face set boundary flag settings in PBVH_FACES

Assets: Show all assets indirectly nested inside the active catalog

The asset catalog design was always that the active catalog would also
display all assets of its child catalogs (or grand-childs, etc.). This
is one of the main characteristics that differentiates catalogs from
usual directories.

Sybren prepared this on the asset catalog backend side with
56ce51d1f75a. This integrates it into the Asset Browser backend and the
UI.

Cleanup: Remove unused variable and include

Fix: Geometry Nodes Handle Type Selection Fix

Fix the selection logic on the Handle Type Selection node to work
as intended:

(Left is Selected AND Left is ChosenType)
OR
(Right is Selected AND Right is ChosenType)

Sculpt: fix set limit surface crashing

Also tweaked smallhash hash function.

Geometry Nodes: Curve Trim Node Update

This update allows the Trim Curve node to use float field inputs
for the start and end inputs. These fields are evaluated on the
spline domain.

Differential Revision: https://developer.blender.org/D12744

Fix: Unable to select left and right in set handle type node

The "enum" RNA flag was missing.

GPencil: Simplify code removing extra function

The function was not doing anything and only was calling another function.

UI Tree-View API: Enforce active item to be un-collapsed

Makes sure that the active item of a tree never has collapsed parent
items, which can be confusing if it happens. E.g. for the asset catalogs
UI, the active catalog decides which assets are visible. Having it
hidden while being the main factor deciding which assets are visible is
quite confusing.

I think it makes sense to have this at the UI Tree-View level, rather
than doing it manually in the asset catalog code for example. Seems like
something you'd commonly want. We can make it optional in the API if
needed.

Renamed the `set_active()` function to make clear that it is more than a
mere setter.