Blender Git Loki

Keymap: only use MMB workaround whe MMB is enabled

Using double-click with selection breaks selection cycling behavior
(making you have to wait to click again to cycle-select the next item).

Fix problem with unused color slot in framebuffer on some bugged AMD GPUs

Differential Revision: https://developer.blender.org/D4035

Fix T57770: Edit-mesh wireframe cage select fails

Merge branch 'master' into blender2.8

Cleanup: unused var, style

DRW: Optimize adjacency data creation a bit

This is a very small improvement and only concerns wireframe update.

My tests.
old 6fps > new 7fps > baseline (wireframe disabled) 10fps

Cleanup: no need to access final mesh

Merge remote-tracking branch 'origin/master' into blender2.8

Fix (devtalk 4053): Collada build with older cmake versions broken

GHOST: WGL: Silence Errors when testing opengl context versions

Fix T58407: Wire frames are not showing with subdivision surfaces

Cleanup: unused function

Fix own mistake in recent rB74361eebe68c.

One cannot assign to Class.__dict__, that is not a 'real' dictionnary...

Thanks to @JacquesLucke for noting the issue.

Fix (unreported, related to T58210) LaplacianDeform binding state incorrectly reported by RNA.

LaplacianDeform binding handling is a catastrophee in CoW context,
because half of the binding (the laplacian solver cache thingy) is not
saved, and can be re-generated on the fly from stored vcos.

This means that binding is not only done when hitting 'bind' button, but
also at file load, and when some things change.

And this utterly breaks with CoW design, not sure how to fix, will add a
task about that.

But this also means that NULL laplacian solver cache pointer is not a
good check to know whether it is binded or not, only stored vcos are
relevant for that (and the binding flag, of course).

Fix T58210, Part II: Surface Deform modifier (un)binding is broken.

This fixes/clarifies Surface Deform evaluation code that does the
binding, since that part should only be called outside of depsgraph
evaluation, with orig data-blocks and not CoW ones.

Now we have a decent amount of asserts and checks to ensure eveything
works as expected.

Also had to add a special case to get target's mesh in binding case,
since often target's evaluated mesh is not available, in that case (and
in that case only), we can actually compute that mesh (because we are
out of depsgraph evaluation).

Fix T58210, part I: Surface Deform modifier (un)binding is broken.

Binding and unbinding *has* to happen outside of 'normal' depsgraph
evaluation of modifiers now that we have CoW, otherwise persistent data
stored in modifier data are always lost!

Note that this is only first step of the fix, modifiers code needs also
some work. Surfacedeform one is in next commit, Laplacian case is much,
much more complicated to handle, given how it uses its cached data. :(

Minor cleanup in Laplacian deform modifier DNA code.

Merge remote-tracking branch 'origin/master' into blender2.8

fix: Collada: remove Class from method definition in header file

UI: reduce area splitting action zone size.

This would overlap with buttons in the header. It's smaller to hit, but
still wider than the outlines for resizing, so hopefully it's fine.

Differential Revision: https://developer.blender.org/D4033