Blender Git Loki

Cleanup: prepended bc_ to utility functions (satisfy name convention)

All utility functions from collada should contain the prependix bc_
Some of the new added functions did not comply to the convention.

Cleanup: calculating sample frames get scene action instead of object

Previously the functions for calculating the sample frames have used
the animated object from where they derived the active action. This was
not necessary. I changed the api so that the scene action is now
directly specified for better reading.

Cleanup: Added Helper functions to get Scene actions

This is mostly for cleaning up the AnimationExporter for
supporting the upcoming feature "export all animations".
I also added a few extra checks for existing animations,
which potentially avoid crashes when the calling functions
do not check for existing animations.

Removed const qualifier from EvaluationContext parameter and adjusted the class methods to reduce future merge conflicts in Blender2.8

fix Collada: wrong usage of pointer and hidden redeclaration

* Suspicious usage of pointer:

short *type = 0; // this creates a null pointer

When this is later used for anything then blender would crash.
After following the code and check what happens i strongly believe
the author wanted to use a short and not a pointer to a short here.

* local variable where reused later in same function
While this did no harm, i still felt it was better to use a different
name here to make things more separated:

- moved variable declaraiotns into loop (for int a=0; ...)
- renamed uv_images to uv_image_set
- renamed index variable from i to j in inner loop that
reused same index name from outer loop

Cleanup Collada: Removed duplicate variable setting

Cleanup: avoid redeclaration of iterator in same function

The iterator was redeclared 3 times. I fixed this to avoid future issues.
I commit separately because so the changes are less cluttered all over
the place.

Cleanup Collada: Avoid unintentional reuse of previous defined variable

The variable child was redeclared multiple times in the same function.
While this has not created any issues i still changed this to avoid
confusion and keep the usage of the variables more local.

Fix Collada: Avoid unnecessary and even wrong check on unavailable data

The function validateConstraints() potentially causes a null pointer
exception. I changed this so that the function returns a failure as soon
as the validation fails. This avoids falling into the null pointer trap.

Cleanup Collada: Make sure index variables are not reused

The variables i and j have been declared before in the same function.
I changed the names to mi and mj to keep things clear.

Cleanup Collada: make sure float array is initialised

This is just to silence a compiler warning and keeping
the code clean. The actual code never uses uninitialised
array elements.

Refactor Collada: combined 2 almost identical functions into one

The 2 methods add_bezt() and create_bezt() do almost the same.
I combined them both into add_bezt() and added the optional parameter
eBezTriple_Interpolation ipo

Fix problem when change mode if no brushes

When chnage mode, create the default brushes if they are missing.

Fix problem with Brush Datablock icons

The icons of grease pencil brushes did not work because the poll return false.

WIP: more work moving datablock

All references to old bGPDbrush struct has been removed and basic functionality working again now.

Still the icons of the brushes are missing.

WIP: Fist step moving bGPDbrush to Brush datablock

Still a lot of work ahead, but this commit is to save the situation before remove bGPDbrush struct.

Merge branch 'master' into soc-2017-normal-tools

Partially revert "Fixed vertex groups not respected with keep sharp in modifier."

This reverts some changes from commit a7a4beecb208d12a00d550e3ebf4e2a37730fa6b.

Fix T54274, and rename option --window-borderless to --window-fullscreen

Fixed vertex groups not respected with keep sharp in modifier.

Also fixed some other trivial issues.