Blender Git Loki
Git Commits -> Revision a9cacb2
Revision a9cacb2 by Philipp Oeser (blender-v2.83-release, tmp-2.83-cycles-rtx3-kernels) September 2, 2020, 13:03 (GMT) |
Fix T80159: Custom Normals Averaging crash after clearing custom split normals data Clearing custom split normals would get rid of the CD_CUSTOMLOOPNORMAL layer - but editing data `lnor_spacearr` would be kept. Adding a CD_CUSTOMLOOPNORMAL layer (if none exists yet) should be done in `edbm_average_normals_exec` / `BKE_editmesh_lnorspace_update` / `BM_lnorspace_update` / `BM_lnorspacearr_store`. The thing is that if the editing data `lnor_spacearr` would still be valid after `Clear Custom Split Normals Data`, blender would happily call `BM_lnorspace_rebuild` instead. Doing that without a CD_CUSTOMLOOPNORMAL layer is asking for trouble. Now clear lnor_spacearr on `Clear Custom Split Normals Data` as well. Thx @mont29 for feedback here. Maniphest Tasks: T80159 Differential Revision: https://developer.blender.org/D8730 |
Commit Details:
Full Hash: a9cacb228041e33bc04a3bc634532164b102c4df
Parent Commit: 006ff64
Lines Changed: +4, -0
1 Modified Path:
/source/blender/editors/mesh/mesh_data.c (+4, -0) (Diff)