Blender Git Loki
Git Commits -> Revision edbbe3b
Revision edbbe3b by Sergey Sharybin (tracking_scopes) March 1, 2021, 14:58 (GMT) |
Tracking: Implement previous/next keyframe scopes The purpose of these scopes is to give more visual reference to a VFX artist: this way the artist can (re)position the marker more accurately when it starts to slide. Before this change it was always more of a guess work about where exactly the marker was at the previous keyframe. There are some weak aspects of the patch related on some rather annoying duplicated lines about calling an utility function for each of 3 scopes. Ideally there needs to be some sort of foreach scope utility, but it is not as trivial as it sounds since the editors implementation code is in ED module, which is not available by blenloader and blenkernel. The interface aspects still needs some work. Currently it is 3 scopes placed in one column. Maybe it needs to be a flow, or some collapsable box? Differential Revision: https://developer.blender.org/D10567 |
Commit Details:
Full Hash: edbbe3bcbc3edd2bd57a7e86bcba5a6771bd21a6
Parent Commit: e81034f
Lines Changed: +312, -45
14 Modified Paths:
/release/scripts/startup/bl_ui/space_clip.py (+11, -1) (Diff)
/source/blender/blenkernel/BKE_movieclip.h (+28, -2) (Diff)
/source/blender/blenkernel/intern/movieclip.c (+105, -4) (Diff)
/source/blender/blenkernel/intern/screen.c (+5, -4) (Diff)
/source/blender/blenloader/intern/readfile.c (+4, -1) (Diff)
/source/blender/blenloader/intern/versioning_290.c (+15, -0) (Diff)
/source/blender/editors/include/ED_clip.h (+4, -0) (Diff)
/source/blender/editors/interface/interface_handlers.c (+29, -14) (Diff)
/source/blender/editors/space_clip/clip_editor.c (+14, -1) (Diff)
/source/blender/editors/space_clip/clip_intern.h (+18, -0) (Diff)
/source/blender/editors/space_clip/clip_utils.c (+42, -0) (Diff)
/source/blender/editors/space_clip/space_clip.c (+15, -15) (Diff)
/source/blender/makesdna/DNA_space_types.h (+3, -1) (Diff)
/source/blender/makesrna/intern/rna_space.c (+19, -2) (Diff)
/source/blender/blenkernel/BKE_movieclip.h (+28, -2) (Diff)
/source/blender/blenkernel/intern/movieclip.c (+105, -4) (Diff)
/source/blender/blenkernel/intern/screen.c (+5, -4) (Diff)
/source/blender/blenloader/intern/readfile.c (+4, -1) (Diff)
/source/blender/blenloader/intern/versioning_290.c (+15, -0) (Diff)
/source/blender/editors/include/ED_clip.h (+4, -0) (Diff)
/source/blender/editors/interface/interface_handlers.c (+29, -14) (Diff)
/source/blender/editors/space_clip/clip_editor.c (+14, -1) (Diff)
/source/blender/editors/space_clip/clip_intern.h (+18, -0) (Diff)
/source/blender/editors/space_clip/clip_utils.c (+42, -0) (Diff)
/source/blender/editors/space_clip/space_clip.c (+15, -15) (Diff)
/source/blender/makesdna/DNA_space_types.h (+3, -1) (Diff)
/source/blender/makesrna/intern/rna_space.c (+19, -2) (Diff)