Blender Git Loki

Follow up to previous commit, proper fix for T46284, incorrect Texture
shading in Texture paint mode and cycles

Revert "Fix T46284: Texture paint, wrong shading mode"

Should fix T46616 but will reintroduce T46284.
The second, original bug needs different handling

This reverts commit 904db487a7b14c31282fe0284612159a836657cd.

Fix T46605: Compositing causes access violation when rendering from command line

Seems was caused by the race condition in the stats printing, should be all fine now.

Nice for 'a' release.

OpenSubdiv: Fix wrong handling of vertex parent

Vertex parent was not registered as CPU data requirement.

Should be in the 'a' release.

Fix T46606: Trackball Rotate jumps releasing shift

Fix broken comment about our WM progress report for python (its not a progress bar at all).

Fix T46604: Crash in ChainPredicateIterator instantiated without predicates.

Also fixed a potential crash in the copy constructor case.

Freestyle: minor speed-up by omitting the calculation of the smallest edge size.

BlenderFileLoader tries to find the smallest edge size but the computed value is not used.

Fix: Prevent warnings from popping up when trying to edit driver expressions from buttons

Previously, a warning was added to provide feedback to users trying to change the values
of driven properties why their edits would not have any effect on the propeerty. However,
it turned out that instead of only showing up when the user tried to increment/decrement/slide
the property's value, it was also firing everytime they were trying to edit the expression.
That however is not what we want at all!

This fix assumes that BUTTON_STATE_TEXT_EDITING is used for expression editing, and
BUTTON_STATE_NUM_EDITING (or everything else) refers to the user trying to adjust the
value normally.

Fix T46599: Copy Rotation behaves erratically when Use Y is disabled

When the "Use Y" option in the Copy Rotation constraint is disabled, the constraint
behaves eratically when rotating all the target on all axes at the same time.
This is partially to be expected due to the way that euler rotations work
(i.e. the rotation orders stuff - you should use a rotation order based on most to
least important/significant rotations). Hence, by locking Y, you're causing accuracy
problems for Z.

What was not expected though was that changing the rotation orders on the objects
involved (for the record, it's the constraint owner that counts) did nothing.
It turns out that for objects, the rotation order settings were getting ignored!
This commit fixes this problem, and this particular case can be resolved by using
"XZY".

Notes:
* Since all object constraints were previously working on the assumption that they
used XYZ (default) order, it is possible that this change may have the unintended
consequence of changing the behaviour of some rigs which relied on the buggy
behaviour. Hopefully this will be a rare occurrence.

Fix: Missing update after scrubbing time in Graph Editor

Sometimes the timeline header didn't update after time-scrubbing in the graph
editor ends, leaving the "Pause" button visible until the next refresh of the
timeline (e.g. on mouse over)

Fix: X-axis values in Graph Editor should not be displayed as timecodes in "Drivers" mode

Fix error in bone UI

Fix invalid exceptions w/ preview API

D1575 by @januz

Fix T46538: Mark and Clear Seam in UV Editor, assigning Hotkeys.

UV Editor keymap is not bound to a given editor (spacetype)...

Fix related to T46538: do not popup choice menu of mark/clear seam UV editor op invoke when prop is already set!

Correct own error w/ snap-scale T46503

Don't use nan for comparisons.

Fix ffmpeg memory leaks

- audio_stream wasn't freed.
- audio/video stream + context weren't freed on failure.

Fix ffmpeg saving long paths

Was checking wrong length on string copy.

Fix for error w/ RenderView in ImageView list