Blender Git Loki

OpenSubdiv: Use BLI module math functions

It became rather annoying to have those functions duplicated.

Surely, it's not really nice it's actually a bad level call,
but similar thing is happening in OCIO and Cycles.

IMO, it's better than having functions re-implemented, and
have this solved with new OpenGL pipeline.

OpenSubdiv: Make drawing code a bit more flexible for FVar width

OpenSubdiv: Properly support active UV layer in textured view

OpenSubdiv: Lay down fundamentals to support multiple UV maps

OpenSubdiv: Get number of UVs from topology refiner

This allows us to store more than one UV layer in the UVs array.

OpenSubdiv: Cleanup, please don't use insanely long lines

OpenSubdiv: Cleanup, don't use camel case for variable names

Correct mistake comparing vertices

use bool consistently, fix redundant conditional

Redundant conditional (line 939) found with PVS-Studio T48917

There?s still a lot of true/false, 1/0, SELECT/DESELECT usage nearby.
Not a problem, just confusing to read.

remove double-checked conditions

Checking a condition right after we?ve checked it (and it hasn?t
changed). Most of these are trivial to understand.

split_quads in convertblender.c:
It seems quads should be processed and triangles should be marked as
not needing split. So I removed the outer vlr->v4 check.

Found with PVS-Studio T48917

Add Subdivide Edge-Ring to menu

Fix T48926: Subdivide edge-ring crash

Also resolves: T34294

fix confusing operator precedence

Assigning within a conditional is confusing and error prone so I
rewrote in a more straightforward way.

Found with PVS-Studio T48917

fix enum type / values mismatch

Found with PVS-Studio T48917

fix null pointer dereferences

Found with PVS-Studio T48917

fix comparison of identicals

Some of these check that dimensions match before running code that
assumes they do match.

For imb_stereo3d_write_anaglyph I *assume* this change reflects the
intended behavior. Before it was always grabbing alpha from buffer 0.

Found with PVS-Studio T48917

Cleanup: pass pointer to texture draw state

BMesh: compare face angles as angles cosine

Fix broken proxy object deletion.

Check to ensure we do not delete last instancing of an indirectly used object (forbidden
because it creates 'ghost' objects user have no real way to re-instance) was defeated by
the backward pointer 'proxy_from', which generated a 'false' indirect usage of (local)
proxy object itself (the one we are trying to delete).

Fixed by actually considering that ID usage as local if proxy object itself is local
(because that pointer actually does not 'pertain' to the object holding it, but to its proxy).

Yeah, it's... complicated, twisted and ugly - it's proxy.

fix typo in condition

(A - A).norm() is always 0 so condition is always true.

(A - B).norm() and (B - A).norm() both compute the same distance so I
picked one to match surrounding code.

Found with PVS-Studio T48917