Blender Git Loki

Cycles: Fix possible uninitialized XML read state which might cause crashes

Fix T44541 aka gigapixel image render support in blender.

Moral of the story: Make sure that size_t is used whenever pointer
arithmetic is involved. For images, that basically means whenever any
squared dimensions are involved. Casting an operand to size_t early in
the operation is usually sufficient to force the entire operation to
size_t.

There might still be places lurking where we don't support this
correctly. This has been tested with render pipeline, quite a few image
functions (meaning we can paint on such images now, albeit somewhat
slowly ;) ) and export to jpeg. Too many places in code to check so I
guess we'll be handling cases as they come.

Don't try this at home unless you have an immense ammount of RAM.
First GPixel render of suzanne in the multiverse can be found here:

http://download.blender.org/demo/test/suzanne-billion-pixel.jpg

Can be viewed from blender (takes about 3.3 GB after loading but may
take more during loading so 8GB might be more safe to try this).

Fix T44556: Crash on the World Properties > Preview

Issue was caused by de-referencing NULL pointer, rres did not have any
views because nothing was rendered yet.

Needs more closer look about where else such a de-reference could happen.

Fix T44548: Cycles Tube Mapping off / not compatible with BI

Was a typo in original implementation, probably a result of some code reshuffle
happened for optimization reasons.

View3D: expose size as a distance in units

also note that size/rotation doesn't work for camera views. see T44511

CMake: Solve compilation error from path with a space

Correct docstring

Correct missing break

Cleanup: style

Cleanup: Update some comments and add ToDo.

Cycles: Record all possible volume intersections for SSS and camera checks

This replaces sequential ray moving followed with scene intersection with
single BVH traversal, which gives us all possible intersections.

Only implemented for CPU, due to qsort and a bigger memory usage on GPU
which we rather avoid. GPU still uses the regular bvh volume intersection code, while CPU now uses the new code.

This improves render performance for scenes with:
a) Camera inside volume mesh
b) SSS mesh intersecting a volume mesh/domain

In simple volume files (not much geometry) performance is roughly the same
(slightly faster). In files with a lot of geometry, the performance
increase is larger. bmps.blend with a volume shader and camera inside the
mesh, it renders ~10% faster here.

Patch by Sergey and myself.

Differential Revision: https://developer.blender.org/D1264

Fix T44484: Edge-split corrupts mesh

Splitting non-manifold edges could produce duplicate edges.

BMesh: use BM_face_loop_separate_multi for rip

Resolves bug over-splitting non-manifold connected edges.

BMesh: add BM_face_loop_separate_multi

New utility function to handle splitting off multiple loops from a face at once.

BMesh: simplify/optimize loop splitting logic

To split off a single loop, was splitting all fans off the vertex, then merging back together (except for one).

Now simply splits off one loop.

BMesh: refactor edge-vert swapping into API call

BMesh: minor change to swap-vert api

- assert if the verts not in the edge (all callers assume success)
- rename to bmesh_disk_vert_swap
- swap src/dst arg order.

Cycles: Fix wrong termination criteria in SSS volume stack update

Another issue spotted with Thomas.

Cycles: Fix wrong order in object flags calculations

Object flags are depending on bounding box which is only available after
mesh synchronization.

This was broken since 7fd4c44 which happened quite close to the release
and oddly enough was not sopped by anyone. Render test is coming for this.

Was spotted by Thomas Dinges while working on another patch.

Fix filename has "new render view" suffix reported by Jason van Gumster (Fweeb)

Bug introduced in f8540d7fd5a47bc9d1d676d5aaaa0de379c71637