Blender Git Loki

Fix Saving startup file changing paths of the current file

Saving the startup file now uses "Save Copy", so paths are preserved.

Fix T86231: Saving startup file always remaps relative

Tests: don't write thumbnails when running tests

Also replace WM_OT_read_factory_settings with WM_OT_read_homefile
so the preferences don't have to be reloaded.

Cleanup: include '--open-last' in "Misc Options"

This was using fall-back category "Other Options"
which should be kept empty.

Cleanup: redundant struct declarations

Cleanup: use non-zero comparisons for event modifiers

Use event modifier checks that follow most of Blender's code.

Cleanup: use BM_mesh_copy_init_customdata utility function

Cleanup: comments

Cleanup: use const arrays

Cleanup: number literals

Cleanup: replace Py_CLEAR with Py_DECREF in bpy.app modules

In this case, there is no benefit to using Py_CLEAR
as the value will never be NULL and can't be used later on.

PyAPI: correct garbage collection for StructRNA types

By default objects are no longer GC tracked, this removes some overhead
although it's not significant in my own testing.

- Only enable GC for StructRNA when 'WITH_PYTHON_SAFETY' is on.
- Only track StructRNA when their 'reference' is set.
- Add missing NULL check when 'WITH_PYTHON_SAFETY' is on
and objects new objects be created.

Fix logic for calling PyObject_GC_UnTrack

All tracked objects need a matching un-track,
also remove redundant Py_XDECREF call.

macOS/GTests: add_dependencies to fix build error

When building `install`, linking blender_test fails because
test libraries do not exist. This happened on lite + Xcode. Error in
{rBdcb2821292f962951e88f146cb304160f21f73da}.

Reviewed By: #platform_macos, brecht
Differential Revision: https://developer.blender.org/D10607

UI: Remove extra blank space for decorators in FCurve modifiers

None of these properties can be animated, so it doesn't make sense
to leave space for decorators on the right side of the panels. In fact
that is what was intended, but they were not manually disabled
in all of the panels.

Fix T86042 EEVEE: incorrect irradiance bake

The environment (world) irradiance wasn't correctly skipped.

Geometry Nodes: Allow clearing an attribute text field

Because pressing enter will choose the current search item from the menu,
and there was no search item with an empty string, it was impossible to
clear the text of an attribute text field. This commit adds a simple "X"
icon in the top row when you delete the string.

UI: Allow translation for node error messages

This commit exposes the strings used in the node error messages for
localization. It also changes the message tooltip creation to
automatically add the period at the end, to be more consistent with
the (arguably bad) design of other tooltips in Blender.

Calling `TIP_` directly in the node implementation files allows us to
continue using `std::string` concatenation instead of passing variadic
arguments. It's also more explicit about which part of the message is
translated and which isn't. The files already include the translation
header anyway.

macOS/Ghost: Remove redundant nil check after initWithContentRect

AppKit?s NSWindow.h has NS_ASSUME_NONNULL_BEGIN, and only methods/
properties explicitly marked nullable will ever return nil.

Reviewed By: #platform_macos, sebbas
Differential Revision: https://developer.blender.org/D10603

macOS/Ghost: Fix memory leak.

`new` allocates a new object that needs to be autoreleased.

Reviewed By: #platform_macos, sebbas, ankitm
Maniphest Tasks: T86222
Differential Revision: https://developer.blender.org/D10597