Blender Git Loki

Fix T83989: Attribute Math node ignores its operation setting

T83989 observes that the Attribute Math node always adds its
operands regardless of its operator setting. This was caused
by an oversight committed in rB23233fcf056e42, which overlooked
adjusting the exec function to use the new storage location.

Differential Revision: https://developer.blender.org/D9909

Cleanup: Correct comment

fix T83880: Added check for valid context object to avoid null pointer exception when no object in scene

UI: Fix text padding in some list widgets

Normally, pure text buttons have no padding at their edges so they
align with edges of buttons, see D9058. However, in several cases
there are labels aligned to the right side of a list widget row,
so they're missing padding against the right edge.

The fix is to use emboss = 'NONE' for such labels, which changes
the drawing style, adding padding on the right edge. (Normally so
labels aligned with the text from non-embossed buttons). This is
not necessarily intended, but it works properly.

For more information, see the revision.

Differential Revision: https://developer.blender.org/D9874

UI: Slightly improve alignment in selection tool icons

Parts of the tool icons for box, circle, lasso, and tweak select that were
meant to be flat or at a 45 degree angle were slightly misaligned, making
the edge look blurry.

VSE: Add options to select neighboring handles

Options added to `sequencer.select_handles()` operator.

Reviewed By: ISS

Differential Revision: https://developer.blender.org/D7707

UI: Reorder enums in render results image editor header

The convention is to put the label at the bottom of the enum, or in the
spot furthest away from the button. This commit reorders the items in
the "Slot", "Layer", and "Pass" menus to be consistent with this
convention. It also reorders the numbering so that higher numbers are
lower.

The original patch was by Adrian Newton (@TFS), with slight changes
and additions.

Differential Revision: https://developer.blender.org/D7142

VSE: Remove cost calculation from cache

This value was meant to be used for keeping images that are slowest to
render in cache. Method of measurement was flawed, because it doesn't
take UI overhead into consideration.

Cache panel is to be removed because users should not have to tweak
settings like this. It is not useful for development either, therefore
it is removed completely.

VSE: Fix incorrect cache memory usage calculation

If image is cached twice, it's size has been counted twice as well, but
only image reference count is increased, not memory usage.

Use `MEM_get_memory_in_use()` instead of size own tracking.

Movie Clip: Annotation UI Improvements

Previously, the Annotation panels were a bit buggy in the movie clip editor.
This commit fixes the issue of the panel in the sidebar would disappear
when selecting "Tracks" if no tracks were added to the clip.
To solve this issue the user if given a label text saying "No annotation source"

This commit also removes some grease pencil operators from the toolbar
that do not work with the new annotation system.

This commit also moves the data source choice from the toolbar to the sidebar.
This is needed to migrate the current toolbar to the new tool system
(see T83612)

Some old invalid code was also removed.

Reviewed By: #grease_pencil, antoniov

Differential Revision: https://developer.blender.org/D9729

Compositor: New Exposure Node

This new node increases the radiance of an image by a scalar value.
Previously, the only way to adjust the the exposure of an image was with
math node or using the scene's color management.

Reviewed By: jbakker

Differential Revision: https://developer.blender.org/D9677

Cleanup: Use typedef for UI emboss type enum

Previously both `char` and `int` were used to represent this enum.

Differential Revision: https://developer.blender.org/D9903

Cleanup: Split SEQ_sequencer.h file

Cleanup: Rename BKE_sequencer functions

API functions get SEQ_ prefix.
Intern functions get seq_ prefix

Functions also have appropriate category included in name.

Fix T83868: Button animation states no longer visible without emboss

This bug was caused by making it so that non-embossed modifier icon
buttons could become an operator button and retain their red highlight
for disabled modifiers. The icon button needs emboss turned off, but
in earlier versions of Blender, `UI_EMBOSS_NONE` would be overridden
by animation or red alert states.

Instead of abusing "NONE" to mean "none unless there is animation or
red alert", this commit adds a new emboss flag for that situation,
`UI_EMBOSS_NONE_OR_STATUS`, which uses no emboss unless there is an
animation state, or another status. There are only a few situations
where this is necessary, so the change isn't too big.

Differential Revision: https://developer.blender.org/D9902

Fix build error after previous commit

I tested building so many times while making this patch, but somehow
the previous commit was missing a padding variable, I have no idea how.

Cleanup: Remove unused variables from the bNode struct

In some cases the variables were set but never used anywhere.

Differential Revision: https://developer.blender.org/D9889

Cleanup: Use true and false for booleans

Cleanup: Declare variables where initialized

Also decrease scope of some variable declarations.

Cleanup: Use bool instead of int