Blender Git Loki

Fix missing custom-property escaping for whole-character keying set

Custom properties with characters that needed escaping
had f-curves created with invalid paths.

Fix missing string escaping in RNA_path_append

This was escaping the '[' character, which isn't needed for quoted text.

Tests: fix 'ctest -j' running multiple tests at once

bl_blendfile_io & bl_blendfile_liblink shared a filename,
which could make these tests fail.

Cleanup: remove unused function bc_find_bonename_in_path

BLI_string: return NULL from BLI_str_quoted_substrN on failure

This was returning an empty allocated string, however almost
all callers checked if the return value was NULL before freeing,
making for misunderstandings on the intended use of this function.

BCAnimationSampler::initialize_curves for example detected the
f-curves animation type to 'bone' based on a non-NULL return value
which never failed.

Also fixes two leaks where the the result of BLI_str_quoted_substrN
wasn't freed.

Fix BLI_str_quoted_substrN use with escaped strings

BLI_str_quoted_substrN didn't unescape the resulting string,
yet all callers were using this with animation paths which are
created using BLI_str_escape().

- Fix BLI_str_quoted_substrN use with escaped strings by calling
BLI_str_unescape().

Note that it's possible we want an a version of this function that
keeps escape characters. This could be added if it's required.

- Fix end quote detection using BLI_str_escape_find_quote
checking for `"` isn't reliable since an even number of back-slashes
before a quote means it's not escaped.

BLI_string: extract quote utility into BLI_str_escape_find_quote

Duplicate logic for this exists in BLI_str_quoted_substrN,
which doesn't properly support escaping.

Cleanup: use snake-case instead of camel-case

Cleanup: avoid '_ln' suffix

Use '_len' or '_line_number'.

Cleanup: declare variables when used (bpy)

Cleanup: declare variables when used (RNA)

Cleanup: remove unnecessary vars in RNA token reading

Cleanup: rename BLI_strescape to BLI_str_escape

Prepare for `BLI_str_unescape` which doesn't read well
without the separator.

Fix BLI_str_escape with control characters, add unit tests

BLI_string: add BLI_str_unescape utility function

Performs the reverse of BLI_str_escape.
This allows logic to be removed from RNA path handling.

BLI_string: support escaping additional control character

Add support for escaping a, b & f for completeness,
currently it's not required.

RNA: use BLI_str_unescape utility for parsing escaped strings

PyAPI: add bpy.utils.unescape_identifier

Utility to perform the reverse of `bpy.utils.escape_identifier`

Fix T82852: Cycles crashes when editing a mesh with adaptive subdivision

The issue is caused by stale data on the Mesh Node which is not cleared
during synchronizing since the socket API refactor so that we can detect
changes. However, synchronization only updates the sockets of the Mesh,
so other properties were left with outdated values.

This caused an underflow when computing attribute size for undisplaced
coordinates as it was using the current number of vertices minus the
previous count of subdivision vertices, which at this point should be 0.

Added a simple method to clear non socket data. Also modified
Mesh.add_undisplaced to always use an ATTR_PRIM_GEOMETRY as the data is
not subdivided yet and it avoids any further issues regarding computing
attribute sizes.

Cleanup: Use const for filter queries