Blender Git Loki

Fix (unreported) broken logic in `BKE_collection_add_from_collection`.

That function was adding given new collection to all ancestors of the
reference one, instead of only to its immediate parents.

Fix T82996: Library Overrides: Duplicate of overridden collection on Resync

Properly use given reference pointer in
`lib_override_library_create_post_process` when it is a Collection one
too.

Cleanup: Graph Editor, refactor selection operators

Extract initialisation code of box selection into separate functions.

No functional changes.

Reviewed By: zeddb, sybren

Differential Revision: https://developer.blender.org/D9196

Cleanup: Animation, clean up action group rearranging code

Some minor cleanups to make an upcoming bugfix easier.

No functional changes.

Fix T81628: Moving Python-made channels freezes Blender

Fix various problems in the Action Group rearranging code. All fixes are
necessary to resolve the bug.

- Before groups are rearranged, the channels are moved into their
respective groups (so no longer referenced by `action->channels`). A
temporary group is made for ungrouped channels. The code made
assumptions about the channels being in the same order as the groups;
that assumption has been removed.
- Looping over channels in an Action Group should stop when reaching the
last channel, and not until `NULL`.
- After all the reshuffling is done, the `action->channels` linked list
wasn't terminated properly. Now `first.prev` and `last.next` are set
to `NULL` to avoid infinite loops.

Tracking: Clarify tracks and options storage once again

This is something not-so-trivial to see from just reading code, which
shown an important of proper comments and clear naming.

Main source of confusion was that it is not immediately clear that
AutoTrack context is to see all tracks, but tracking to only operate on
selected ones.

Tracking: Make image accessor own what it needs

Previously image accessor was sharing array pointer for tracks access.
Now it is possible to pass a temporary array valid only during the
initialization process.

Should be no functional changes.

Windows/Ninja: allow parameters for rebuild.cmd

The windows build leaves a convenience helper script
in the build folder called, rebuild.cmd. This change
passes any parameters you give rebuild.cmd to ninja
so you can easily pass it additional parameters without
having to edit the batch file manually.

GPencil: New operator to reset Vertex Colors

This operators reset the vertex color information of the strokes.

If nothing is selected, all strokes are reset. If any is selected, only selected strokes are reset.

Also added a new menu Paint in Vertex Color mode.

Differential Revision: https://developer.blender.org/D9647

Tracking: Cleanup, remove unused argument from image accessor

Tracking: Cleanup, remove unused field

Was re-introduced after previous round of cleanups when was merging
refactor and master branches.

Tracking: Cleanup, use explicit frame match option

No functional changes, just allows to potentially extend the options
in the future, and also makes code more explicit.

Tracking: Cleanup pattern match DNA definition

Wrong comment was used for enumerator.

Also made it a real typed enumerator to ease use in the implementation
code.

Should be no functional changes.

Fix T83203 BGL: shader.program wrongly always returns 0

This was a leftover from the 2.91 GPU module refactor.

This is an exception that should be removed when we remove BGL.

Tracking: Cleanup, finish pass of comments in the context

Some fields are still not really documented, but they are subject of
refactor/fix which will happen shortly.

Tracking: Cleanup, replace clip user with frame number

Makes it more clear from intent and usage point of view.
The user was not used for anything else than frame number.

Tracking: Cleanup, more clear variable naming

A no-functional-followup of the previous commit.

Tracking: Fix missing frame remap for plane tracks

Tracking track which is used for plane track and movie clip having
a scene frame offset would have trigger re-calculation from a wrong
frame.

Tracking: Cleanup, clear variable names and indentation

Should be no functional changes.

Tracking: Cleanup, unused field in autotrack context

Was only assigned to truth, always. Never read back.