Blender Git Loki

Cleanup: Declare variables where initialized, lower scope

Also use "r_" prefix for return arguments in a few places.

Fix Tests for Weld Modifier with KD-Tree

Fixes the failing tests and reintroduces the KD-Tree solution.

Reviewed By: mano-wii

Differential Revision: https://developer.blender.org/D9013

LibOverride: Cleanup: reserve debug messages to debug builds.

LibOverride: Better handling of cleanup of 'insert' operations in collections.

Before, it might have been possible in some cases (when there were no
items at all anymore in the collection) to miss that cleanup step,
leaving ghost useless and invalid operations around.

Fix T78343: Most properties of Ocean modifier should not be animatable.

Properties that are only used when initializing the simulation cannot be
animated (the changes in their value would not be taken into account).

LibOverride: Tweak messages when some sub-item is not found when applying overrides.

Fix T81161: Bad properties context panel placement loading old files

These breadcrumbs used to be a panel in 2.79 and 2.80 development.
If a file was saved in those versions, and the panels rearranged in a
version that didn't have this panel, its sortorder would be changed
even though it wasn't visible or even used in that version.

A simple fix is to use a new ID name for the new version of this
panel in 2.91. "Buttons" is an old name anyway.

Cleanup: Miscellaneous code improvements

- Declare variables where initialized
- Return early in some cases
- Use "i" as an iteration index variable
- Use bool instead of int where applicable

Fix constrain plane not being set in tranform code

Error introduced in rB388b9162469650c

UI: Improve curve geometry property tooltips

These tooltips mostly just repeated the property names, which is not
helpful at all. Changing that leaves space to be much more specific
about what the properties actually do.

Differential Revision: https://developer.blender.org/D8994

Cleanup: silence [-Wshadow] warnings

Introduced in rBd5a6b3b18c5d.

GPencil: Fix unreported missing context menu for pinned mode

When the mode was pinned, the context menu did not display the color wheel for the vertex color mode.

Fix T80937: Changing the contrain axis does not return to the scene orientation

This was the behavior in old versions of blender.

During a transformation operation, when pressing a contrain key, the chosen
orientation is that of the scene.

If you press the same key, the orientation changes to Global or Local.

However, if you choose another contrain axis with the orientation changed,
the orientation does not return to the set for the scene.

It remains Global or Local.

Now when changing a contrain axis, no matter what the current orientation is,
it always returns to the scene orientation.

Weld Modifier: Disable the KD Tree solution

This solution is causing the modifier regression test to fail.

Also fix a mistake to allocate `vert_dest_map` twice.

Animation: set Action `idroot` at assignment instead of just at evaluation

Actions are either locked to a specific ID type, or "floating". Actions
in the floating state are now locked when they are assigned to an ID block.
Previously (rB94b99b5d4a7c20cf2) this was done at evaluation time, which
caused various problems:
- The ID type was set on the evaluated copy, and inconsistently flushed
back to the original.
- A newly created Action could not be assigned to an Action constraint,
unless a depsgraph evaluation was be forced first.

This is now resolved by calling `BKE_animdata_set_action()` to set the
action (instead of direct assignment) where possible, and calling
`BKE_animdata_action_ensure_idroot()` otherwise.

Manifest Task: https://developer.blender.org/T80986

Cleanup: animation, reduce complexity of RNA update function

Reduce complexity of `rna_SpaceDopeSheetEditor_action_update()` by flipping
conditions and returning early.

The depsgraph tagging has slightly changed, in that the depsgraph is not
tagged at all when there is no actual animation data added. I still see
this as a non-functional change, though, as in that case nothing changed
and tagging and re-evaluating wouldn't make any actual difference.

No functional changes.

Cleanup: animation, remove commented-out code

The code was commented out in rB6307c65534f6d5cf29d08220cea0dbcca9a0e118,
11 years ago.

No functional changes.

Cleanup: animation, deduplicate "can edit action" logic

Move "action editable" check from RNA code to Blender kernel
`BKE_animdata_action_editable()`.

No functional changes.

Cleanup: document and simplify `BKE_animdata_set_action()`

Simplify `BKE_animdata_set_action()` by flipping some conditions and using
early returns, and document which parameters can be `NULL`.

No functional changes.

Fix T80998: DDS Image files are not displayed correctly

Blender 2.91 only. Due to recent refactoring the compressed texture
formats missed the conversion to its GL counterpart.