Blender Git Loki

Cleanup, Asset Catalogs: turn default catalog filename into a constant

Instead of hard-coding a path somewhere in the source, store it in a named
string constant.

No functional changes.

Cleanup: Asset Catalogs, make path separator static class member

Make `AssetCatalogService::path_separator` a static class member. There is
no need to make such constants per-object.

This in itself isn't that interesting a change, but it will be relevant
for an upcoming new string constant.

No functional changes.

Merge remote-tracking branch 'origin/master' into temp-asset-browser-catalogs

Cleanup: Assets, add asset catalog documentation comments

Cleanup: Assets, remove unused forward/namespace declarations

Cleanup: Asset Catalogs, make fields private and add `_` suffix.

Partially revert "Cleanup: Assets, move AssetLibrary struct to global namespace"

This reverts the namespace changes from commit
784b97e280c1ba479822d0fba6ebfce0b91595d4.

Cleanup: Assets, move AssetLibrary struct to global namespace

Move `blender::bke::AssetLibrary` to the global namespace, causing the
C `struct AssetLibrary` to refer to the same object as the corresponding C++
struct.

Also move `intern/asset_library.hh` to `BKE_asset_library.hh`,
mimicking `BKE_geometry_set.hh`.

This makes the C and C++ pointers compatible, cleans up the code a bit,
and aids in debugging.

No functional changes.

Cleanup: C++ to C comment style

No functional changes.

Fix pointer ownership issue in `AssetCatalogService::parse_catalog_file()`, and solve some feature envy by adding a few `AssetCatalogDefinitionFile` methods.

Filelist: load AssetLibrary (and thus catalogs)

Load `AssetLibrary` struct when refreshing the filelist. This primarily
loads the asset catalog definition files.

Merge remote-tracking branch 'origin/master' into temp-asset-browser-catalogs

Merge remote-tracking branch 'origin/master' into temp-asset-browser-catalogs

Merge remote-tracking branch 'origin/master' into temp-asset-browser-catalogs

Assets: add AssetLibrary struct

Add `AssetLibrary` struct that owns a pointer to an `AssetCatalogService`.

The `struct AssetLibrary` is an opaque struct that C code can just pass
around. It is created with `BKE_asset_library_load(library_path)` and
freed with `BKE_asset_library_free(the_pointer)`.

Note that this API is still experimental.

Merge remote-tracking branch 'origin/master' into temp-asset-browser-catalogs

Merge remote-tracking branch 'origin/master' into temp-asset-browser-catalogs

Merge remote-tracking branch 'origin/master' into temp-asset-browser-catalogs

Asset Catalogs: add catalog ID to AssetMetaData

Add field `char AssetMetaData::catalog_id[MAX_NAME]`, to hold the
catalog ID of the asset. This field should be set using the
`BKE_asset_metadata_catalog_id_set()` function, which ensures that there
are no spaces in the ID and that the field is not too long.

For now only used to show in the UI, for development/debugging purposes.

Asset Catalogs: test space in asset catalog path

Test for the support of spaces in asset catalog paths.