Blender Git Loki

Cleanup: replace STREQLEN with STRPREFIX for constant strings

Cleanup: use 'BKE_' prefix for initialization functions

Cleanup: de-duplicate code for instancing objects when linking

Ref D8843

Cleanup: Use LISTBASE_FOREACH macro

Cleanup: clang-format

Missed this last commit.

Cleanup: use ELEM macro

Cleanup: use ELEM macro (>2 args)

Cleanup: doxygen comments

Cleanup: doxygen comments in ghost

Use colon after parameters, use hash to reference symbols.

Cleanup: Use descriptive variable names

Cleanup: BLI_noise

Use common prefix as this collided with existing API's (eg BLI_voronoi).

Also expand some non-obvious abbreviations:

- 'g' -> 'generic'
- 'vl' -> 'variable_lacunarity'
- 'V' -> 'v3'

Cleanup: use snake case for BLI_args API

Cleanup: use bool argument in BLI_noise

Cleanup: remove unused BLI_argsArgv

Cleanup: follow our code style for float literals

Cleanup: remove unused BLI_turbulence1

A slightly modified version of BLI_turbulence1, unused for years.

Cleanup: use string APPEND/PREPEND

Replace 'set' with 'string(APPEND/PREPEND ...)'.
This avoids duplicating the variable name.

Fix T82400: Dyntopo detail size edit operator visual glitch

Just a missing immUnbindProgram

Reviewed By: sergey

Maniphest Tasks: T82400

Differential Revision: https://developer.blender.org/D9459

Fix Dyntopo detail size preview orientation not matching the cursor

Used the sampled cursor normal when available instead of the raycast face normal.
This makes the preview match the previous orientation of the cursor.

Reviewed By: sergey

Differential Revision: https://developer.blender.org/D9460

Cleanup: unused variable