Blender Git Loki

Cleanup: use ELEM macro

Cleanup: follow our code style for float literals

Cleanup: use bool argument in BLI_noise

Cleanup: BLI_noise

Use common prefix as this collided with existing API's (eg BLI_voronoi).

Also expand some non-obvious abbreviations:

- 'g' -> 'generic'
- 'vl' -> 'variable_lacunarity'
- 'V' -> 'v3'

Cleanup: remove unused BLI_turbulence1

A slightly modified version of BLI_turbulence1, unused for years.

Cleanup: use snake case for BLI_args API

Cleanup: remove unused BLI_argsArgv

Cleanup: use string APPEND/PREPEND

Replace 'set' with 'string(APPEND/PREPEND ...)'.
This avoids duplicating the variable name.

Cleanup: transform.h comments, use doxy sections

Cleanup: sort structs, files

Cleanup: clang-format

Cleanup: unused variable

UI: Tweaks to the Warning Icon

Warning Sign Alert Icon given a more rounded border.

Differential Revision: https://developer.blender.org/D9443

Reviewed by Pablo Vazquez

Fix T81915: Draw Face Sets not working with deformed sculpt mesh

The draw face sets brush uses the poly center when used in meshes to increase
its precision when working in low poly geometry. For this to work with deformed
meshes, the deformed coordinates from the PBVH should be used instead.

Reviewed By: sergey

Maniphest Tasks: T81915

Differential Revision: https://developer.blender.org/D9424

Fix memory leaks in sculpt mode trimming tools

BKE_mesh_free() seems to not free the meshes correctly, so using BKE_id_free() instead.
The looptri array was also not freed.

Reviewed By: sergey

Differential Revision: https://developer.blender.org/D9426

Fix T82400: Dyntopo detail size edit operator visual glitch

Just a missing immUnbindProgram

Reviewed By: sergey

Maniphest Tasks: T82400

Differential Revision: https://developer.blender.org/D9459

Fix Dyntopo detail size preview orientation not matching the cursor

Used the sampled cursor normal when available instead of the raycast face normal.
This makes the preview match the previous orientation of the cursor.

Reviewed By: sergey

Differential Revision: https://developer.blender.org/D9460

Move "Camera Parent Lock" from preferences to Object Relations

"Camera Parent Lock" can be useful when rigging cameras, but it is not
intuitive, and has also generated a lot of confusion (bug reports).
This is because it breaks the fundamental parent <-> child relationship
conventions in Blender, and there is no indication that it's intended
without diving into the preferences.

This commit moves the setting to the object level, and exposes it in
the relations panel in the property editor. It is exposed for every
object type because any object type can be "View Locked" in the 3D view.
The property description is also updated to reflect this change and be
more specific without getting too long.

In the future this could become a more general feature of the transform
system, but for now it is limited to "Lock Camera to View".

Differential Revision: https://developer.blender.org/D9239

Fix T82423: Add modifier key back into keymap

Commit rBf5080c82dd915db6c7b9dd68a52aaaccf2600137
accidentally remove the Shift modifier key from
the `AUTOCONSTRAINPLANE` shortcut.

Differential Revision: https://developer.blender.org/D9480

Fix T82164: Knife tool draws huge vertices after using bgl.glPointSize

Since it is possible to have multiple draw callbacks, (some of which
use bgl and others gpu), check and force the reset of the drawing status
at the end of each callback.

Differential Revision: https://developer.blender.org/D9476