Blender Git Loki

Cleanup: Remove unnecessary constructor argument

All attributes should be writeable, it is now only needed for the
legacy `normal` attribute on meshes.

Geometry Nodes: Optimize curve builtin attribute exists check

Calculating the number of points is overkill here, if there are many splines.
The `exists` check just needs to know if there are any points at all.

Cleanup: Rearrange code, rename function

Move the static functions higher in the file so they are usabl
for an upcoming patch, and make it use clearer names instead
of overloading a function name.

Fix T92314: Auto naming of the Vertex Group doesn't work for Grease
Pencil

Not naming the auto-generated vertexgroup after the selected bone was
just confusing (since the group would not have an effect), so now use
similar code that is used for meshes for greasepencil as well.

Maniphest Tasks: T92314

Differential Revision: https://developer.blender.org/D12906

Cycles: replace integrator state argument macros

* Rename struct KernelGlobals to struct KernelGlobalsCPU
* Add KernelGlobals, IntegratorState and ConstIntegratorState typedefs
that every device can define in its own way.
* Remove INTEGRATOR_STATE_ARGS and INTEGRATOR_STATE_PASS macros and
replace with these new typedefs.
* Add explicit state argument to INTEGRATOR_STATE and similar macros

In preparation for decoupling main and shadow paths.

Differential Revision: https://developer.blender.org/D12888

Cleanup: consistently use uint32_t for path flag

Cleanup: fix outdated comment and use of atomics

This is only used by a single device, not need for thread safety.

Cycles: optimize volume stack copying for shadow catcher/compaction

Only copy the number of items used instead of the max items.

Ref D12889

Cycles: reduce GPU state memory a little

* isect Ng is no longer needed for shadows, for main path needed for SSS only
* Reduce rng_offset and queued_kernel to 16 bits

Ref D12889

Cleanup: minor refactoring in preparation of main and shadow path decoupling

Ref D12889

Cleanup: use a common prefix in static functions

This helps identify where the function came from.

Fix 1 frame delayed orientation in Placement Gizmo

Error in {rB69d6222481b4}

Fix failing `AssetLibraryService` test by removing test code

Remove the code I had hoped to fix in rB3edae09e, the fix was unreliable.

No functional changes to Blender.

Cleanup: Use simpler method to create attribute lookups

Instead of switch statements, make use of generic virtual arrays
so the code is shorter and easier to read.

Differential Revision: https://developer.blender.org/D12908

Cleanup: clang format

Fix T92246: sculpt crash displaying statistics in certain situations

It seems possible to switch object selection (if `Lock Object Modes` is
turned off) and end up with an object that has a SculptSession but a
NULL PBVH.
(I was not able to repro from scratch, but file from the report was
clearly in that state).

This would crash in displaying scene statistics.

While there might be a deeper fix (making sure PBVH is available early
enough -- possibly using `BKE_sculpt_object_pbvh_ensure`,
`sculpt_update_object` or friends), there are also many checks in tools
for PBVH, so the situation seems to be somewhat vaild/expected also in
other places.
So to fix this, just check for a non-NULL PBVH, returning early
otherwise.
Note: this leaves us with displaying 0/0 Faces & Vertices in the borked
case until an operation takes place that updates the PBVH.

Maniphest Tasks: T92246

Differential Revision: https://developer.blender.org/D12904

Cleanup: fix compiler warning

Fix T92311: Snap to faces in edit mode with x-ray enabled doesn't work

The `use_occlusion_test` parameter test was accidentally removed in
{rB91c33c8b9952}

Fix: dangling pointer caused use-after-free

The old code only worked when built-in nodes are only unregistered
at most once while Blender is running. However, this is not the case
when running certain unit tests such as `AbstractHierarchy*`
in `blender_test`.

Found by Sybren, thanks.

UI: Reduce vertical margin between panels

In an attempt to reduce scrolling. This can be re-visited if a kind of switch
between "compact" and "comfortable" UI size is implemented in the future.