Blender Git Loki

Fix T92113: On assets, replace "Fake User" button with "Clear Asset" button.

Change is simple enough, but we abuse a bit the UI code here to get a
similar 'look' as the fake user button for the new Asset one, while
still being able to call an operator instead of editing directly a RNA
value.

Reviewed By: Severin, sybren

Maniphest Tasks: T92113

Differential Revision: https://developer.blender.org/D12839

Revert "Fix T92136: Leak accessing evaluated depsgraph data from Python"

This reverts commit 0558907ae674ebe81dc8910a6615fc32ce675d70.

Based on discussion with Sergey, having Python references to un-expanded
data should not happen - this change needs to be reconsidered.

Sculpt: fix shape keys being destroyed by
SCULPT_UNDO_GEOMETRY/SYMMETRIZE pushes.

* Also cleaned up bmesh conversion parameters in
a few other places.

Fix Cycles viewport after session reset

Happens i.e. when changing compute device.

A more proper follow-up to the on-demand display driver creation change.

Fix T92136: Leak accessing evaluated depsgraph data from Python

Fix Cycles assert in viewport after recent change

Create display early on, so that ready_to_reset() passes assert test
for use for display actually configured.

Sculpt: add buttons in sculpt header to toggle
vertex color drawing.

* Added two buttons to toggle between vertex
and material color modes in workbench drawing
mode.
* They are labeled "Colors" and "Normal" to
avoid confusion; "Vertex" is ambiguous, while
"Material" might be taken to impley "EEVEE."
* For now they only show up if a sculpt paint
brush is active.
* Updated startup.blend so the sculpt layout
has vertex drawing mode on by default.

Fix possible integer overflow in Cycles baking

Ensure math happens on size_t type instead of int followed by a cast
to the size_t.

Fix Cycles backing issues when using multiple devices

The pixel accessor was not aware of possible offset in the
pixel padding causing some slices of the result not being
properly padded.

Sculpt: BMLog stuff

* BMLog now has a more fine-grained logging
facility to track the call chains
that produce specific log elements.
* Wrote a new function in bmesh_core.c to
dump local geometry around an element to
stdout in .obj format.
* Edge collapse now properly handles the
fact that bmesh handles sharp flags
inversely, i.e. edges *not* marked
with BM_ELEM_SMOOTH are sharp.

* Wrote a new BMLog API that handles elements
undergoing topological changes a bit better.
- BM_log_[edge/face]_[pre/post]
- Idea is to call the _pre before calling
collapse or split edge, then _post afterwards.
- No longer need to assign new IDs
in certain cases to avoid confusing BMLog.
- Other parts of BMLog may now be redundant;
need to check.

* Deleted some #if 0'd code
* Fixed a bug in BLI_smallhash_ensure_p, it didn't properly
set up state for when smallhash is used as a very simple
set.

Fix: Stops assert when baking in debug mode.

When baking in a debug build running gdb it kept asserting because a GL context was being created outside the main thread.

To fix this the patch only creates the GL context is only created for rendering (when it is actually used).

Reviewed By: sergey

Differential Revision: https://developer.blender.org/D12767

Geometry Nodes: Add "XYZ" label to instance on points scale

Geometry Nodes: Add units to set radius node inputs

Sculpt: shapekey fixes

* Fixed the completely broken shapekey conversion
in BM_mesh_bm_from_me; this bug is most likely
in master as well.
* Note that, while shapekeys now work in dyntopo
it does not represent a complete sculpt layers
implementation; the layers are still stored in
world space.
* The motivation for fixing this was to keep
dyntopo from destroying shapekey data, which
was the only form of custom attributes it didn't
support.
* That was because shapekeys were never being converted
to custom attributes for bmesh to begin with, the
conversion code was quite broken.

In addition to all this, this commit also has
a fix dyntopo collapse fixes.

BLI: Overload float4x4 multiplication-assignment operator

This looks a lot nicer than writing `mul_m4_m4_post` instead.

Differential Revision: https://developer.blender.org/D12844

Fix T91809: Crash on undo with empty field inferencing

Some runtime data that stores which sockets can be fields and which
can't is not stored in the file, but only calculated when necessary.
When opening a file, the node tree update function was called, which
recalculated this data, but that was explicily turned off for undo.

This exposes a fundamental issue with undo, the ID caching system for
undo, and how it relates to node trees in particular. Ideally this call
couldn't be necessary at all. In the future it could be removed by
adding a runtime struct to node trees, and calculating its contents
on-demand instead of preemtively.

Differential Revision: https://developer.blender.org/D12699

Fix T92160: Geometry Proximity node can produce invalid values

Check when the node fails to create BVH trees, and fill the result
with zero in that case, which is most likely the expected value when
the node encounters an error. Warnings will be added with a separate
patch.

Cleanup: Fix comment formatting and grammar

Asset Catalogs: Refresh catalog simple name when assigning catalog ID

When assigning a new catalog ID to an asset, also refresh the "catalog
simple name". This "simple name" is stored on the asset metadata next to
the catalog UUID, to allow some emergency data recovery when the catalog
definition file is somehow lost.

Fix T92149: Crash in delete geometry node after curve fill node

There was only a check for the component but not for if it was empty.
Because the curve fill node produces an empty curve component, a
nullptr was read, causing a crash. Generally nodes shouldn't produce
empty components, but currently we cannot rely on that fact.

Differential Revision: https://developer.blender.org/D12838