Blender Git Loki

Cycles: Cleanup, always use parenthesis

Easier to read/follow, and more robust for the further changes.

Cycles: Cleanup, indentation in preprocessor

Cycles: Cleanup, variable names

Don't use camel case for variable names. Leave that for the structures.

Cycles: Cleanup, useless new lines

Cycles: Cleanup, braces after function definition

I wouldn't mind switching fully to Google style, but i am against of
mixing two different styles in same project. So just stick to brace
at the new line after function definition.

;115;0cCycles: Cleanup, use ccl_restrict instead of ccl_restrict_ptr

There were following issues with ccl_restrict_ptr:

- We already had ccl_restrict for all platforms.

- It was secretly adding `const` qualifier to the declaration,
which is quite weird since non-const pointer can also be
declared as restricted.

- We never in Blender are using foo_ptr or FooPtr type definitions,
so not sure why we should introduce such a thing here.

- It is absolutely wrong from semantic point of view to put pointer
into the restrict macro -- const is a part of type, not part of
hint for compiler that some pointer is never aliased.

Fix T51537: Light passes are summed twice for split kernel since denoise commit

Denoise commit introduced kernel_write_result() which saves light passes, so
no need to call both kernel_write_result() and kernel_write_light_passes() from
the split kernel.

Weirdly enough. kernel_write_result() does not take care about debug passes.

Fix T51556: Sequencer - White Balance Modifier - Masking is not honored

Fix/workaround T51070: Cannot scale procedural texture in compositor

The issue is coming from some weird semi-finished canvas feature, which
was remapping coordinate without applying any differential on the sampling
ellipse (in fact, there is no ellipse, sampling think is always a single
pixel).

The whole thing is just weak in the compositor, for now just bring behavior
back to how it was prior to optimization (multithreading) commit.

Compositor: Remove unused funciton

Cleanup: removing dummy legacy dashed line shader.

Dashed requires geom shader, which was not available with older OpenGL,
now that we are on 3.3 we do not need that dummy workaround anymore.

Merge branch 'master' into blender2.8

Conflicts:
source/blender/blenloader/intern/versioning_270.c
source/blender/depsgraph/intern/depsgraph_tag.cc
source/blender/editors/mask/mask_draw.c

Fix empty-image draw size

Was out of sync with 2.7x.

Fix T51553: Cycles Volume Emission turns black when strength is 0 or color is black

The problem was that Cycles implicitly uses a transparent surface shader when only
volume nodes are used, but since the black emission shader gets optimized away,
it was no longer detected and therefore no transparent surface was used.

Therefore, the shader now stores whether volume nodes were connected before
optimizing.

Fix T51506: Wrong shadow catcher color when using selective denoising

Cycles: Fix random noise pattern seen with multiscatter bsdf and split kernel

Differentials were unset if roughness was low giving undefined behavior.

Fix T51555: Cycles tile count is incorrect when denoising is enabled

Now rendered and denoised tiles are counted and displayed separately.

Remove use_display_lists option

Fix T51502: Cycles denoising not using correctly aligned width for NLM on CUDA

OpenGL: call glProgramUniform only if version >= 4.1

Otherwise crash! Called from OpenSubdiv setup code. Might start using this in more places...