Blender Git Loki

Fixed an error and warning on Linux from previous commit.

Addressed comments of reviewers on D8623.

Almost all changes asked for by Campbell and Jacques have been
addressed. The clang-tidy fixes will happen in the next commit.

Merge branch 'master' into lanpr-under-gp

Merge branch 'master' into greasepencil-edit-curve

Merge branch 'master' into greasepencil-object

Silence some warnings; minor changes.

Since `map_bump_strength` was changed to have a
leading space, length should be increased too.

Pass by reference to avoid copy.

Release resources if not moved by the owner in Mesh and
Curve creation code.

Cleanup: add r_ prefix.

No functional change.

r_offsets -> r_offset.

Fix after merging master

Use blender::StringRef instead of std::string_view.

Context:
{rB9616e2ef78f0}
{rBc521b69ffb68}

In MTL parser, `Vector.first_index_of_try` result was being compared
with `string::npos` which gave correct results since `npos` is -1,
but is wrong semantically. So fix it.

Merge branch 'master' into fcurve-modifier-panels

Use remove_prefix for easy transition to StringRef.

The relevant search functionality was added to StringRef in
{rBc521b69ffb68}

Move object creation code from constructor.

Also add destructors with assert in case caller doesn't
own the object.

Rename `blender_object_` to `mesh_object_` to be like
`curve_object_`.

Cleanup: Comments, clang-format.

Remove unused uv vertex index offset.

Edit FaceElem list outside polygon creating code.

`new_faces` was a lie after it was extended. Better is all_faces.

Merge branch 'master' into soc-2020-testing-frameworks

Removed cloth Pressure and Self Collision tests

added warning and disable self collisions for non closed meshes

Cleanup: move break statements into case body, or remove if follwing a return.

fixed bug when switching mesh types