Blender Git Loki

Cycles: More tweaks to make specialized BVH traversal matching

Cycles: Avoid redundant intersection pre-calculation

Cycles: Cleanup, sync some comments across different traversal

Cycles: Cleanup, always use parenthesis

Makes it simpler to compare different traversal algorithms.

Lowercase includes for psapi.h and dbghelp.h windows includes.
This makes cross compilation a little less painful

Fix T49385: Copy buffer is not from pose mode. Report Error

Quick fix for now, need to unlock studio here as well.

Proper fix would be to modify API a bit and pass flags which will
prevent expand called on bmain perhaps. But this we should discuss
a bit,

Cycles: Move BVH constants to an own files, so they are easily re-usable

Remove null-check of argument which is attributed as non-null

This was logically incorrect and was causing warning and compilation
errors with strict compiler flags.

CacheFile: make sure SpinLock is destroyed when exiting Blender.

Missed in rB62b1cdd6.

Cycles: Fix typo that would sometimes result in subsurf modifier being disabled

Various cleanups related to button locking

* Rename uiBut.lockstr to disabled_info
* Remove unreachable code
* Replace duplicated check with assert
* Replace overly ambitious check with assert
* Add comments

Cleanup: Completely replace/remove uiBut.lock

Old leftover from pre 2.5 days. Now handled through UI_BUT_DISABLED button flag.

Minor corrections for previous commit

Was using wrong argument name in doxygen comment. Also reduced scope of vars.

Sorry for the noise :/

BLI_listbase: Add/use utility to move link (BLI_listbase_link_move)

We were calling BLI_remlink and then BLI_insertlinkbefore/after quite often. BLI_listbase_link_move simplifies code a bit and makes it easier to follow. It also returns if link position has changed which can be used to avoid unnecessary updates.

Added it to a number of list reorder operators for now and made use of return value. Behavior shouldn't be changed.

Also some minor cleanup.

Fix T49245: Adaptive Subdivision with Auto Smooth causes weird mesh appearance

GPencil: Don't show error popup when strokes can't be reordered further

Was spawning error popup each time user tried to move a stroke higher or lower than the list allowed. We don't do that anywhere else and it's not really useful info for the user. So rather not bother her.

Cycles: Fix update of subdivision meshes when global dice rates change

When subdivision settings were moved from meshes to objects this was missed,
should work fine now.

Cycles: Soft minimum for dice rates

Use 0.5 as a soft minimum for dice rates to help from setting them too
low. Lower values can still be set by typing in the value.

Cycles: Adaptive isolation

Idea here is to select the lowest isolation level that wont compromise quality.
By using the lowest level we save memory and processing time. This will also
help avoid precision issues that have been showing up from using the highest
level (T49179, T49257).

This is a pretty simple heuristic that gives ok results. There's more we could
do here, such as filtering for vertices/edges adjacent geometric features that
need isolation instead of checking them all, but the logic there could get a
bit involved.

There's potential for slight popping of edges during animation if the dice
rate is low, but I don't think this should be a problem since low dice rates
really shouldn't be used in animation anyways.

Reviewed By: brecht, sergey

Differential Revision: https://developer.blender.org/D2240

GPencil: Fix memory leak using stroke arrange OP